Skip to content

refactor: verify-yakit-sign-build 打包文件拆分 逻辑简化#3966

Open
hjhke wants to merge 1 commit into
masterfrom
hejiahui/feat/signTest
Open

refactor: verify-yakit-sign-build 打包文件拆分 逻辑简化#3966
hjhke wants to merge 1 commit into
masterfrom
hejiahui/feat/signTest

Conversation

@hjhke

@hjhke hjhke commented Jul 9, 2026

Copy link
Copy Markdown
Contributor

Create a merge commit

Copilot AI review requested due to automatic review settings July 9, 2026 03:45

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR refactors the verify-yakit-sign-build GitHub Actions workflow to simplify the packaging/signing flow by consolidating version/metadata preparation, reducing duplicated steps, and adding caching for signed Yak engine artifacts to speed up repeated verification builds.

Changes:

  • Consolidates engine version resolution + software naming/version derivation into a single “Prepare build metadata” step.
  • Adds an actions/cache layer for signed macOS Yak engine artifacts (zips + sha256 files) keyed by engine version.
  • Simplifies/streamlines render asset preparation and macOS artifact verification + upload naming.

@github-actions

github-actions Bot commented Jul 9, 2026

Copy link
Copy Markdown
Contributor

PR CI 汇总

状态:全部通过

  • ✅ i18n(zh/en)
  • ✅ ESLint(renderer src/main)
  • ✅ TypeScript(renderer src/main)
  • ✅ ESLint(engine-link-startup)
  • ✅ TypeScript(engine-link-startup)
  • ✅ 图片/视频体积
  • ○ Vitest(main / renderer / engine-link;test 同目录·别名·相对路径)(skipped)
  • ✅ Prettier

由 pull_request test workflow 自动生成

@hjhke hjhke force-pushed the hejiahui/feat/signTest branch from 32080eb to e2c27a3 Compare July 10, 2026 08:30
@hjhke hjhke requested a review from Copilot July 10, 2026 08:31

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 3 comments.

mkdir -p bins bins/scripts
wget -q -O bins/engine-version.txt https://yaklang.oss-accelerate.aliyuncs.com/yak/latest/version.txt
echo "ENGINE_VERSION=$(tr -d '\n' < bins/engine-version.txt)" >> "$GITHUB_ENV"
echo "SOFTWARE_VERSION=$(node -p "require('./package.json').version.replace(/-ce|-ee/g, '')")" >> "$GITHUB_ENV"
Comment on lines +32 to +34
for f in auto-install-cert.zip start-engine.zip google-chrome-plugin.zip; do
zip -qj "bins/scripts/$f" bins/flag.txt
done
Comment on lines +42 to +46
chmod +x ./packageScript/script/signature.sh
./packageScript/script/signature.sh
wget -q -O bins/yak_darwin_amd64.sha256.txt "${YAK_BASE}/yak_darwin_amd64.sha256.txt"
wget -q -O bins/yak_darwin_arm64.sha256.txt "${YAK_BASE}/yak_darwin_arm64.sha256.txt"
./packageScript/script/signature.sh build
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants