Skip to content

refactor: remove SlideBuilder.customize - #7

Merged
ya7010 merged 3 commits into
mainfrom
remove-slidebuilder-tap
Mar 12, 2026
Merged

refactor: remove SlideBuilder.customize#7
ya7010 merged 3 commits into
mainfrom
remove-slidebuilder-tap

Conversation

@ya7010

@ya7010 ya7010 commented Mar 11, 2026

Copy link
Copy Markdown
Owner

Summary

  • remove the redundant SlideBuilder.customize API
  • keep SlideBuilder.tap as the single callback escape hatch
  • update slide tests to use tap only

Testing

  • uv run ruff check src/tppt/pptx/slide.py tests/test_slide.py tests/test_table.py
  • uv run pytest tests/test_slide.py tests/test_table.py -q

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR removes the redundant SlideBuilder.tap API and standardizes slide customization on SlideBuilder.customize, updating related tests accordingly.

Changes:

  • Removed SlideBuilder.tap from src/tppt/pptx/slide.py.
  • Updated slide tests to validate customize() behavior (including raw python-pptx access).
  • Deleted dead/unreachable tap-based table test code and simplified table imports.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
src/tppt/pptx/slide.py Removes the tap builder API, leaving customize as the supported hook.
tests/test_slide.py Migrates tap tests to customize and removes tap-specific coverage.
tests/test_table.py Drops dead tap-based test code and trims unused imports.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@ya7010 ya7010 changed the title refactor: remove SlideBuilder.tap refactor: remove SlideBuilder.customize Mar 11, 2026
@ya7010
ya7010 merged commit 37b8196 into main Mar 12, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants