fix(linux): niri hint offset via show-geometries - #1123
Open
ivelieu wants to merge 1 commit into
Open
Conversation
this uses the `niri msg -j show-geometries` command provided by niri-wm/niri#3305.
Owner
|
Amazing work! i have added a |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this uses the
niri msg -j show-geometriescommand provided by niri-wm/niri#3305.Description
as discussed on the discord, this is blocked on niri merging a method to query precise window offsets.
Initially I tried doing this implementation with niri-wm/niri#4147, but I realised only after doing it that the data it provides alone is insufficient to get the offsets from waybar/dms/noctalia and niri's horizontal padding. Using niri-wm/niri#3305 is much simpler.
I don't expect this to get merged until upstream does, for now this is just for others that may want a fix in the meantime like me.
Target Platform
Type of Change
feat— New featurefix— Bug fixrefactor— Code restructuring (no behavior change)perf— Performance improvementdocs— Documentation onlytest— Adding or updating testschore— Build, CI, dependencies, toolingCross-Platform Checklist
//go:build darwin)CodeNotSupported)General Checklist
just fmt)just lint)just test)just build)Screenshots / Recordings
neruhintlabels.mp4