Fixes temperature widget showing blank/empty on modern Linux systems#271
Open
vm-wylbur wants to merge 1 commit into
Open
Fixes temperature widget showing blank/empty on modern Linux systems#271vm-wylbur wants to merge 1 commit into
vm-wylbur wants to merge 1 commit into
Conversation
│ │
Modern temperature sensors don't use the "_input" suffix that the │ │
filtering logic expected. This caused the temperature widget to │ │
remain empty despite sensors being detected. │ │
│ │
- Updated defs() to include all sensors instead of filtering │ │
- Added safety check for empty labels in temp collection │ │
│ │
Fixes temperature display on systems with modern hwmon drivers
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes temperature widget showing blank/empty on modern Linux systems.
Problem
The temperature filtering logic was looking for sensors with "_input" suffix (legacy hwmon convention), but modern temperature sensors don't use this naming anymore. This caused the
defs()function to return an empty list, preventing any temperatures from being displayed.Solution
defs()intemp_linux.goto include all detected sensors instead of filtering for "_input" suffixtemp_nix.gofor empty sensor labelsTesting
Tested on Linux system with 28 temperature sensors (AMD CPU, ASUS motherboard, NVMe drives, etc.). Temperature widget now correctly displays all sensor readings.
Fixes issues where users see empty temperature widget despite having working sensors detected by
gotop --list devices.