Add per-area mowing overrides (outline count/overlap/offset, angle)

[rpeltola]

Summary

Adds optional per-area overrides for the global mowing settings, editable in the area settings dialog:

• outline_count
• outline_overlap_count
• outline_offset (m)
• angle (fixed mow direction)

They live in a collapsible Advanced section (matching the settings fieldset style). It's collapsed by default and auto-expands when the area already has any override set, with a badge showing how many are set. Empty fields fall back to the global config default — the key is simply omitted from map.json.

Context

The ROS v1.2.0 release notes introduced these per-area overrides and noted the app side was still to come:

For now, these attributes must be added manually by editing map.json in a text editor. Support in the OpenMower app is planned.

This PR implements that planned support for all four attributes.

Relationship to #3

This extends #3 (thanks @jrv), which surfaces outline_count. This PR covers all four per-area overrides and implements the advanced collapsible section and "use global default" placeholders suggested in the review of #3.

Details

• Schema: four optional fields added to the area properties (src/stores/schemas.ts).
• Save path is unchanged — properties round-trip through featuresToMap → map.replace; the fields are shown only for mowing areas.
• Angle is entered in degrees and stored as radians in map.json to match ROS (open_mower_ros mower_map/msg/MapArea.msg: angle is radians). The "use global default" sentinels match ROS's overrideOrGlobal (omit the key; ROS uses -1 for the counts and NaN for offset/angle).

Screenshots

• Default collapsed when no values have been added

- Opening when value has been added opens the accordion and shows number of overridden values - All 4 fields and their descriptions visible

Testing

• tsc --noEmit, prettier --check, and next build all pass.
• Verified end-to-end against a live mower: writing the four fields via map.replace persists and reads back correctly, with other areas untouched.

Summary by CodeRabbit

• New Features

  • Added advanced per-area mowing settings for outline count, overlap, offset, and angle.
  • The area editor now shows an expandable advanced section for mowing areas, with a live indicator when overrides are set.

• Bug Fixes

  • Existing saved mowing values are now loaded into the editor correctly, including angle conversion.
  • Empty or invalid override values are cleared so default behavior is used instead of stale settings.

[CLAassistant]

All committers have signed the CLA.

[ClemensElflein]

@coderabbitai full review

Edit: sorry coderabbit for the ping, I added a space too many

[coderabbitai]

@ClemensElflein The PR description images show an Area Settings modal in a dark-themed app UI with green accents:

• The first PR description image shows the modal with fields for Name (Alapihaa part 1), Type (Mowing Area), an Active toggle enabled, and an Advanced accordion that is collapsed. The footer has Cancel and Save buttons.
• The second PR description image shows the same modal with the Advanced section expanded and a green badge labeled 1, indicating one override is set. It includes explanatory text: “Per-area overrides for the global mowing settings. Leave empty to use the global default.” Visible fields include Outline count set to 6 and Outline overlap count showing Global default.
• The third PR description image shows the Advanced section fully expanded with all four override inputs visible: Outline count, Outline overlap count, Outline offset (m), and Mow angle (°). Placeholder/default text includes Global default and Auto-detect, along with helper descriptions for each field.

I’ll run a full review of the PR now.

✅ Action performed

Full review finished.

[coderabbitai]

Warning

Review limit reached

@ClemensElflein, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 33 minutes and 8 seconds. Learn how PR review limits work.

Your organization has used up its prepaid credits, and credit purchases are no longer available. Enable the review add-on in the billing tab to keep reviews running — you're only billed for reviews past your plan's rate limits ($0.25/file).

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based credits.

🚦 How do rate limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 111bddf4-3096-4cc5-8ce3-f61628fc8628

📥 Commits

Reviewing files that changed from the base of the PR and between 8351bb7 and 39572a7.

📒 Files selected for processing (2)

• src/components/map/edit/AreaSettingsDialog.tsx
• src/stores/schemas.ts

📝 Walkthrough

Walkthrough

Adds four optional mowing-override fields (angle, outline_count, outline_overlap_count, outline_offset) to areaSchema, then wires them into AreaSettingsDialog via new string state, hydration from stored properties (radian↔degree conversion), save logic, and a conditional "Advanced" accordion UI.

Changes

Per-area mowing overrides

Layer / File(s)	Summary
Area schema override fields src/stores/schemas.ts	Adds optional angle, outline_count, outline_overlap_count, and outline_offset fields to areaSchema with Zod constraints.
Dialog state, initialization, and save logic src/components/map/edit/AreaSettingsDialog.tsx	Adds degree/radian helpers, override string state fields, advancedExpanded state; useEffect hydrates overrides from stored properties; handleSave applies or removes each override key using a parse/delete helper, converting angle between degrees and radians.
Advanced accordion UI src/components/map/edit/AreaSettingsDialog.tsx	Adds MUI imports and conditionally renders an Advanced accordion (mow type only) with numeric inputs for each override and a chip showing the count of active overrides.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Poem

🐇 Hop hop, the mower now knows,
Each area's angle and how the outline goes!
In radians stored, in degrees displayed,
Override the globals — don't be afraid.
The accordion opens, the chip glows bright,
Every patch of grass mowed just right! 🌿

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly summarizes the main change: adding per-area mowing overrides for outline settings and angle.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[coderabbitai]

The PR description images show an Area Settings modal in a dark-themed UI with green accents and white form cards. The first image shows Name set to Alapihaa part 1, Type set to Mowing Area, an enabled Active toggle, and an Advanced section that is collapsed, with Cancel and Save buttons at the bottom. The second image shows the same modal with Advanced expanded, a green badge labeled 1, helper text saying “Per-area overrides for the global mowing settings. Leave empty to use the global default.”, and fields including Outline count set to 6 plus Outline overlap count showing Global default. The third image shows the full expanded advanced form with all four override fields visible: Outline count, Outline overlap count, Outline offset (m), and Mow angle (°), with placeholders such as Global default and Auto-detect, plus helper text explaining each field.

@ClemensElflein Running a full review now.

✅ Action performed

Full review finished.

[coderabbitai]

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@src/components/map/edit/AreaSettingsDialog.tsx`:
- Around line 93-103: The override parsing in AreaSettingsDialog’s applyOverride
helper is too permissive for outline_count and outline_overlap_count, which are
defined as non-negative integers in the schema. Update the parsing/validation
path used by applyOverride so these count fields only accept whole, non-negative
integers and reject fractional or negative input instead of silently coercing it
via parseInt. Keep outline_offset parsing separate as a float, and make the
change in the AreaSettingsDialog logic that sets properties[key] so persisted
area properties match the schema contract.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 33bd30b0-4017-4b47-950b-ce83f19bccc8

📥 Commits

Reviewing files that changed from the base of the PR and between 1bf5bab and 8351bb7.

📒 Files selected for processing (2)

• src/components/map/edit/AreaSettingsDialog.tsx
• src/stores/schemas.ts

[github-actions]

🧪 Test this PR

A multi-arch image (amd64 + arm64) for this PR has been pushed to:

ghcr.io/xtech/openmower-app:pr-5

OpenMowerOS v2

1. Go to http://<mower-ip>:5001/compose/openmower in your browser.

2. Switch to edit mode.

3. In the compose.yaml editor, add the following above the # Dockge-specific extras shown in the UI line (mind the 2-space indentation, like the other containers):

     app:
       image: ghcr.io/xtech/openmower-app:pr-5
       container_name: app
       ports:
         - 3000:3000
       restart: unless-stopped

4. Add the URL under x-dockge:

   x-dockge:
     urls:
       - http://${HOSTNAME}:8080
       - http://${HOSTNAME}:3000

5. Click Deploy, then open http://<mower-ip>:3000.

Plain Docker

docker run --rm -p 3000:3000 ghcr.io/xtech/openmower-app:pr-5

This comment updates automatically on every new push to the PR.