Skip to content

make batchConn more generic - #200

Open
zjx20 wants to merge 2 commits into
xtaci:masterfrom
zjx20:master
Open

make batchConn more generic#200
zjx20 wants to merge 2 commits into
xtaci:masterfrom
zjx20:master

Conversation

@zjx20

@zjx20 zjx20 commented Apr 25, 2021

Copy link
Copy Markdown

Sometimes we would like to implement a custom net.PacketConn, for example the tcpraw. This patch allows kcp-go to leverage the batching ability provided by the custom conn, if possible.

@codecov

codecov Bot commented Apr 25, 2021

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 86.17021% with 13 lines in your changes missing coverage. Please review.
✅ Project coverage is 83.29%. Comparing base (7450e91) to head (b930b19).
⚠️ Report is 324 commits behind head on master.

Files with missing lines Patch % Lines
batchconn_linux.go 72.22% 6 Missing and 4 partials ⚠️
readloop.go 92.10% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #200      +/-   ##
==========================================
+ Coverage   82.47%   83.29%   +0.82%     
==========================================
  Files          12       11       -1     
  Lines        1889     1910      +21     
==========================================
+ Hits         1558     1591      +33     
+ Misses        260      250      -10     
+ Partials       71       69       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant