Wrap torus start and goal cells onto the board - #7
Open
kvnloo wants to merge 1 commit into
Open
Conversation
findPath/floodFill kept off-board coordinates as graph keys, so wrap
routes returned cells like {-5,0} that no neighbor step can occupy.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
findPath/floodFillkept off-board start/goal cells as graph keys, so wrap routes returned cells like{-5,0}that no on-board neighbor occupies.Wrap those endpoints onto the torus (neighbor clamp from origin is unchanged).
Pin:
node --experimental-default-type=module --test gameblocks/modules/behavior/GridPathPlanner.wrap-start-goal.test.jsSHA:
effc846e1025944edf5d6ac4940815e416caab80No origin issue. Origin target: xt4d/GameBlocks (do not open until Linear HITL is Done).