fix(nexus): remove every in-app GitHub/source link from the Nexus build - #24
Merged
Conversation
… build Nexus Mods does not allow a hosted mod to link to the source repository or to auto-updating builds. The Nexus build already dropped the self-updater; this removes the remaining in-app links to the DLSSync GitHub repo and the last "GitHub Releases" update wording. Centralized behind showSourceLinks (false for the nexus build): - hide the About header GitHub/Sponsor/Report buttons, the footer GitHub profile link, the "Star on GitHub" support action, and the What's New section (sourced from the changelog, which references past releases) - hide the support-nudge Star action and the apply-failure "Report issue" button; the clipboard "Copy report" stays - skip the live GitHub star-count request (no api.github.com call) - share the Nexus mod page instead of the repo - open the Nexus mod page for check-for-updates/changelog; relabel the CTA - drop the "GitHub Releases" mention from the nexus notice and Settings copy Upstream vendor SDK links, Ko-fi, Discord, the website, the Nexus page, and the signed manifest (DLL source) reference are unchanged. Standard build is unaffected (showSourceLinks is true there). Closes #23 Part of #19
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #21. Makes the Nexus build surface zero links to the DLSSync GitHub repository and removes the last "GitHub Releases" update wording, so the package fully meets the Nexus Mods "no source/auto-updating-build links" requirement.
Changes
Centralized behind
showSourceLinks(frontend/src/lib/distribution.ts,falsefor the nexus build). In nexus mode:api.github.comcall)Unchanged: vendor SDK links (NVIDIA/Intel/AMD/Microsoft), Ko-fi, Discord, website, the Nexus page, the signed manifest (DLL source) reference. Standard build unaffected.
Proof
pnpm --filter dlssync-frontend check-> 350 files, 0 errors, 0 warningsbuild:nexus+rgoverfrontend/dist-> 0 matches forplugin-updater|downloadAndInstall|tauri_plugin_updater|plugin:updater|plugin-processCloses #23
Part of #19