ci: check out repo on coverage job to fix Codecov REPORT_EMPTY#7
Closed
alexzhangs wants to merge 1 commit into
Closed
ci: check out repo on coverage job to fix Codecov REPORT_EMPTY#7alexzhangs wants to merge 1 commit into
alexzhangs wants to merge 1 commit into
Conversation
…s REPORT_EMPTY) Codecov's uploader builds its file network from the workspace git tree; the job had no actions/checkout (the lib loads via xsh load), leaving the workspace empty → every upload was REPORT_EMPTY. alexzhangs/xsh works because it checks out. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Collaborator
Author
|
Closing: lib utility coverage is architecturally blocked — xsh sources utilities from /dev/stdin (xsh.sh:1703), so kcov can't attribute coverage to functions/*.sh (only init.sh registers, ~1%). The actions/checkout fix here is correct and necessary, but not worth landing until xsh supports a source-by-path coverage mode. Tracked in alexzhangs/xsh#35. Reverting the Codecov coverage from core; keeping CodeFactor. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The coverage job had no
actions/checkout, so Codecov's uploader scanned an empty workspace and rejected every report asREPORT_EMPTY. Add a checkout (coverage job only; the test loads the lib viaxsh load). Mirrors alexzhangs/xsh's working setup.