fix(csv/parser): pre-type fns array so gawk doesn't empty the parse on Linux#10
Merged
Merged
Conversation
…n Linux
output_variable() built fns[length(fns)+1]; under gawk the first reference length(fns) typed fns as a scalar -> 'attempt to use scalar as an array' -> empty -e/variable output on Linux (BSD awk on macOS tolerated it). Add split("", fns), same fix as ini/parser. Adds a /csv/parser -e regression test (surfaced by xsh-lib/xsql query failures on Linux).
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
csv/parser.awk's
output_variable()builtfns[length(fns)+1]; under gawk the firstlength(fns)typedfnsscalar → empty-eoutput on Linux (BSD awk tolerated it). Addsplit("", fns)(same fix as ini/parser), plus a/csv/parser -eregression test. Surfaced by xsh-lib/xsql query tests failing on every Linux job.