Repository navigation
Conversation
…#2) Fixes four findings from the adversarial review of the Symfony foundation. - Native browser Back keeps the provider selection and Live state consistent; the next player edit no longer silently changes providers. - Native dialog cancellation and closure synchronize accessibility state, including a queued close event after reopening and Turbo cache preparation. - Superseded CI runs can cancel their expensive jobs. Failed or invalid validation-scope decisions still fail the named checks. - HTTP redirects preserve the published HTTPS port, request method, path and query, including IPv6 brackets with or without an incoming source port. Port 443 keeps Caddy's automatic behavior; custom-port redirects preserve existing HTTP routes and explicit automatic-HTTPS settings. Validation: - Both new browser regressions fail against the original code and pass with the fixes. Full PHPUnit/Panther suite: 5 tests, 93 assertions. The fresh-document history case disables BFCache only for its isolated browser; Chrome 154 and randomized test order pass. - PHP, Twig, Symfony YAML/container, entrypoint syntax, actionlint and whitespace checks pass. - Independent adversarial reviews of the final browser, CI and Caddy changes found no remaining actionable issues. - Native Caddy checks cover 22 route configurations / 143 assertions, 10 automatic-HTTPS configurations / 48 assertions and 7 startup/failure checks. - [CI passed on the final commit](https://github.com/xormania/chess-dog/actions/runs/37156525652): Symfony/browser tests and both development and production Docker jobs, including 20 GET/POST authority cases per image (hostname, IPv4 and IPv6, with/without source ports), trusted HTTPS smoke tests, development Mate capabilities and production exclusion of Mate.
Enable native development with shared Docker storage. Review feedback addressed with support for existing host UIDs and real UID 0/33 regression checks. All review threads resolved and all CI checks passed.
Provision the complete native development environment with Devbox. Locked tools, configurable scripts, sandboxed browser setup, and CI validation passed independent review and all hosted checks.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Promote the validated dev branch to master.
Included work:
Validation:
CI also runs on this dev-to-master PR. This PR is left open for maintainer review and merge.