Repository navigation
Share provider operating policy and bound database session admission - #48
Merged
Merged
Conversation
Owner
Author
|
@codex review |
Owner
Author
|
@codex security review |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Codex Review: Didn't find any major issues. Already looking forward to the next diff. Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
🛡️ Codex Security ReviewSecurity review completed. No security issues were found in this pull request. Reviewed commit: Only the user who started this review can view the report in Codex. ℹ️ About Codex security reviews in GitHubThis is an experimental Codex feature. Security reviews are triggered when:
Once complete, Codex will leave suggestions, or a comment if no findings are found. |
xormania
added a commit
that referenced
this pull request
Oct 6, 2026
…#49) ## Why is this PR needed? Promote the reviewed backend changes on `dev` to `master`. These changes prepare Chess-Crawl for a separately maintained hosted product while keeping basic local installations usable. ## What does this PR change? | Delivery PR | Result | | --- | --- | | [#41](#41) | Shared typed environment/TOML configuration, redacted inspection and offline role validation | | [#42](#42) | Workspace provisioning, hashed credentials, revocation and versioned quota policies | | [#43](#43) | Durable acquisition separated from bounded processing, with recovery and atomic game-quota admission | | [#44](#44) | Optional event delivery, bounded retention and polling-only deployment | | [#45](#45) | Independently scalable API/acquisition/processing roles in local Compose and AWS | | [#46](#46) | Anonymous operational backlog, waiting and usage metrics | | [#47](#47) | Bounded asynchronous working-set/export jobs and workspace-owned local/S3 artifacts | | [#48](#48) | Live provider pacing/retry policy and bounded dedicated database sessions | The public backend supplies reusable contracts, credentials, work policies and usage. Customer billing and proprietary chess inference/evaluation/training belong in the separate private product layer; see [hosted-service boundaries](https://github.com/xormania/chess-crawl/blob/dev/docs/saas-integration.md). ### Upgrade notes - Drain older workers and apply migrations `0017`–`0021` before starting this application version. Restart services after changing deployment configuration. See [execution and upgrades](https://github.com/xormania/chess-crawl/blob/dev/docs/execution.md). - Rerun cloud database role bootstrap to update runtime permissions. Existing AWS stacks must replace legacy combined-worker/shared-size parameters and inventory retained queues; see [AWS deployment](https://github.com/xormania/chess-crawl/blob/dev/docs/aws-deployment.md). - Database authentication requires a separately provisioned readiness credential. Asynchronous archive-job admission defaults off; retain artifact storage access while draining jobs or serving existing downloads. See [workspace administration](https://github.com/xormania/chess-crawl/blob/dev/docs/workspace-administration.md) and [archive jobs](https://github.com/xormania/chess-crawl/blob/dev/docs/archive-jobs.md). ## Evidence that it solves the reason | Claim / acceptance condition | Baseline evidence | Result and verification | | --- | --- | --- | | Shared deployment configuration and independently scalable roles | Prior deployment coupled worker stages and configuration paths | Configuration/deployment contracts and real Compose API/Mercure smoke passed in the linked delivery PRs | | Workspace ownership, quotas and durable recovery survive replica concurrency | Hosted-service requirements and focused regressions in the delivery PRs | Real PostgreSQL 18 tests cover credentials, policy revisions, admission races, fencing, recovery and owned artifacts | | Complete integrated backend passes supported offline checks | `master` lacks the eight merged delivery PRs | Final [PR #48 checks](https://github.com/xormania/chess-crawl/pull/48/checks) passed: 1,584 tests on each of Python 3.11 and 3.13, Mypy, Ruff, Bandit, packaged CLI and Compose smoke | Every delivery PR received exactly one `@codex review` and one `@codex security review` after CI was green. Findings were resolved and updated checks passed before merge. The promotion's own CI checks validate its merge result separately. ## Changelog Carries the substantive `Unreleased` entries already accumulated on `dev`; no duplicate promotion entry or release version is added.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why is this PR needed?
Acquisition replicas need shared provider pacing/retry policy that can change without restarting workers, while every process must bound PostgreSQL session usage as replica counts grow.
What does this PR change?
Migration 0021 adds trusted versioned provider policy with optimistic concurrency and append-only history. Provider sessions resolve policy before requests and preserve server cooldowns. Workers recheck pacing, ownership and shutdown after a potentially blocking request-budget reservation; unused reserved bytes are settled if interrupted.
A shared per-process admission controller bounds dedicated database sessions, with finite wait and the existing availability/503 behavior. Setup failures and closure release permits once. Worker validation requires independent execution and heartbeat capacity. Shared runtime and deployment configuration forwards session bounds consistently; changing process bounds requires restart.
Evidence that it solves the reason
89 integrated PostgreSQL guards, 35 policy/cooldown/budget cases, 25 provider cases, 25 HTTP budget cases and 177 actual deployment/configuration contracts passed locally. Ruff, Mypy, Bandit and cfn-lint passed. Full Python 3.11/3.13 offline suites and Compose smoke run in CI.
Changelog
Added shared operating policy and process session admission under Unreleased, plus reservation pacing/shutdown fixes and operator guidance.