Repository navigation
Make event delivery optional and bound notification retention - #44
Merged
Merged
Conversation
Owner
Author
|
@codex review |
Owner
Author
|
@codex security review |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 397b5354e5
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
🛡️ Codex Security ReviewSecurity review completed. No security issues were found in this pull request. Reviewed commit: Only the user who started this review can view the report in Codex. ℹ️ About Codex security reviews in GitHubThis is an experimental Codex feature. Security reviews are triggered when:
Once complete, Codex will leave suggestions, or a comment if no findings are found. |
xormania
added a commit
that referenced
this pull request
Oct 6, 2026
…#49) ## Why is this PR needed? Promote the reviewed backend changes on `dev` to `master`. These changes prepare Chess-Crawl for a separately maintained hosted product while keeping basic local installations usable. ## What does this PR change? | Delivery PR | Result | | --- | --- | | [#41](#41) | Shared typed environment/TOML configuration, redacted inspection and offline role validation | | [#42](#42) | Workspace provisioning, hashed credentials, revocation and versioned quota policies | | [#43](#43) | Durable acquisition separated from bounded processing, with recovery and atomic game-quota admission | | [#44](#44) | Optional event delivery, bounded retention and polling-only deployment | | [#45](#45) | Independently scalable API/acquisition/processing roles in local Compose and AWS | | [#46](#46) | Anonymous operational backlog, waiting and usage metrics | | [#47](#47) | Bounded asynchronous working-set/export jobs and workspace-owned local/S3 artifacts | | [#48](#48) | Live provider pacing/retry policy and bounded dedicated database sessions | The public backend supplies reusable contracts, credentials, work policies and usage. Customer billing and proprietary chess inference/evaluation/training belong in the separate private product layer; see [hosted-service boundaries](https://github.com/xormania/chess-crawl/blob/dev/docs/saas-integration.md). ### Upgrade notes - Drain older workers and apply migrations `0017`–`0021` before starting this application version. Restart services after changing deployment configuration. See [execution and upgrades](https://github.com/xormania/chess-crawl/blob/dev/docs/execution.md). - Rerun cloud database role bootstrap to update runtime permissions. Existing AWS stacks must replace legacy combined-worker/shared-size parameters and inventory retained queues; see [AWS deployment](https://github.com/xormania/chess-crawl/blob/dev/docs/aws-deployment.md). - Database authentication requires a separately provisioned readiness credential. Asynchronous archive-job admission defaults off; retain artifact storage access while draining jobs or serving existing downloads. See [workspace administration](https://github.com/xormania/chess-crawl/blob/dev/docs/workspace-administration.md) and [archive jobs](https://github.com/xormania/chess-crawl/blob/dev/docs/archive-jobs.md). ## Evidence that it solves the reason | Claim / acceptance condition | Baseline evidence | Result and verification | | --- | --- | --- | | Shared deployment configuration and independently scalable roles | Prior deployment coupled worker stages and configuration paths | Configuration/deployment contracts and real Compose API/Mercure smoke passed in the linked delivery PRs | | Workspace ownership, quotas and durable recovery survive replica concurrency | Hosted-service requirements and focused regressions in the delivery PRs | Real PostgreSQL 18 tests cover credentials, policy revisions, admission races, fencing, recovery and owned artifacts | | Complete integrated backend passes supported offline checks | `master` lacks the eight merged delivery PRs | Final [PR #48 checks](https://github.com/xormania/chess-crawl/pull/48/checks) passed: 1,584 tests on each of Python 3.11 and 3.13, Mypy, Ruff, Bandit, packaged CLI and Compose smoke | Every delivery PR received exactly one `@codex review` and one `@codex security review` after CI was green. Findings were resolved and updated checks passed before merge. The promotion's own CI checks validate its merge result separately. ## Changelog Carries the substantive `Unreleased` entries already accumulated on `dev`; no duplicate promotion entry or release version is added.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why is this PR needed?
Polling deployments should not need Mercure, and delivered notifications should not accumulate indefinitely. Durable job/run state and queue dispatch must continue independently of notifications.
What does this PR change?
Adds typed optional event delivery configuration and migration 0019's session-aware outbox guard. Writers continue revisions and dispatch when notifications are disabled. The publisher automatically prunes bounded batches of delivered events; pending notifications remain durable. A trusted
prune-eventscommand can explicitly expire pending events, under the same exclusive publisher lock.Compose forwards the delivery flag to every database client and retention settings to the publisher. A polling overlay omits the publisher and Mercure hub while disabling writer notifications.
The shared runtime catalog validates event policy and rejects a disabled publisher role before loading Mercure credentials. Operators must restart all writers when changing delivery and clients reconcile current API state on subscription recovery.
Evidence that it solves the reason
74 PostgreSQL event/configuration cases and 49 final runtime configuration cases passed locally. Ruff, Mypy and Bandit passed. 143 actual Compose/configuration cases and 69 transport contract tests also passed. Full Python 3.11/3.13 offline suites and Compose smoke run in CI.
Changelog
Added optional event delivery and notification retention entries under Unreleased, with
docs/event-delivery.mdand administration command guidance.