Skip to content

feat(embedding): add EmbeddingGemma 2 support - #5644

Merged
qinxuye merged 2 commits into
xorbitsai:mainfrom
Minamiyama:models/embedding/embeddinggemma-2
Oct 7, 2026
Merged

qinxuye merged 2 commits into
xorbitsai:mainfrom
Minamiyama:models/embedding/embeddinggemma-2

Conversation

@Minamiyama

Copy link
Copy Markdown
Collaborator

Description:

Add google/embeddinggemma-2 as a built-in model with Hugging Face (main) and ModelScope (master) download sources.

  • Add SentenceTransformers, Transformers, and vLLM adapters for text, image, audio, video, and mixed inputs.
  • Support task prompts, an 8192-token context, and 128/256/512/768-dimensional embeddings with normalization after truncation.
  • Use BF16/FP32 and reject FP16, which produces invalid embeddings.
  • Preserve system Torch/TorchVision pins for native backends to prevent incompatible virtualenv dependencies.
  • Provisionally target vllm>=0.32.0 and verify that EmbeddingGemma2Model is registered.

@XprobeBot XprobeBot added this to the v3.x milestone Oct 7, 2026

@qinxuye qinxuye left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Verified the native adapters, multimodal input routing, pooling, dimensions, and dtype handling. All 24 EmbeddingGemma 2 tests passed locally, including the native Transformers/SentenceTransformers mixed-input test. The Windows 3.10 CI timeout is in the unchanged SGLang/Xavier P/D tests; vLLM GPU inference was not run locally.

@qinxuye
qinxuye merged commit c2d2618 into xorbitsai:main Oct 7, 2026
15 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants