Repository navigation
fix: resolve SGLang JIT cache paths before runtime startup #5642
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,65 @@ | ||
| # Copyright 2022-2026 Xinference Holdings Pte. Ltd | ||
| # Licensed under the Apache License, Version 2.0. | ||
|
|
||
| import os | ||
| import subprocess | ||
| import sys | ||
| from pathlib import Path | ||
| from types import SimpleNamespace | ||
|
|
||
| import pytest | ||
|
|
||
| from ..runtime import create_runtime | ||
|
|
||
|
|
||
| @pytest.mark.parametrize("relative", [False, True]) | ||
| @pytest.mark.parametrize("authenticated", [False, True]) | ||
| def test_runtime_children_inherit_canonical_jit_cache( | ||
| tmp_path, monkeypatch, relative, authenticated | ||
| ): | ||
| # SGLang records transient staging files as dependencies under symlinked roots. | ||
| physical = tmp_path / "physical" | ||
| physical.mkdir() | ||
| linked = tmp_path / "linked" | ||
| try: | ||
| linked.symlink_to(physical, target_is_directory=True) | ||
| except OSError: | ||
| pytest.skip("directory symlinks are unavailable") | ||
| monkeypatch.chdir(tmp_path) | ||
| configured = Path("linked/jit") if relative else linked / "jit" | ||
| monkeypatch.setenv("SGLANG_JIT_CACHE_DIR", str(configured)) | ||
| config = {"dtype": "float16"} | ||
| if authenticated: | ||
| config["api_key"] = "credential" | ||
| monkeypatch.setitem( | ||
| sys.modules, | ||
| "sglang.lang.backend", | ||
| SimpleNamespace(runtime_endpoint=SimpleNamespace(RuntimeEndpoint=object)), | ||
| ) | ||
|
|
||
| def runtime(**kwargs): | ||
| assert kwargs == config | ||
| return subprocess.check_output( | ||
| [ | ||
| sys.executable, | ||
| "-c", | ||
| "import os; print(os.environ['SGLANG_JIT_CACHE_DIR'])", | ||
| ], | ||
| text=True, | ||
| timeout=30, | ||
| ).strip() | ||
|
|
||
| assert create_runtime(runtime, **config) == str(physical / "jit") | ||
| assert not (physical / "jit").exists() | ||
|
|
||
|
|
||
| @pytest.mark.parametrize("configured", [None, "", "~/.cache/sglang/jit"]) | ||
| def test_runtime_default_jit_cache_is_expanded(monkeypatch, configured): | ||
| if configured is None: | ||
| # Track the absent key so teardown also restores direct runtime writes. | ||
| monkeypatch.setenv("SGLANG_JIT_CACHE_DIR", "unused") | ||
| monkeypatch.delenv("SGLANG_JIT_CACHE_DIR", raising=False) | ||
| else: | ||
| monkeypatch.setenv("SGLANG_JIT_CACHE_DIR", configured) | ||
| expected = str((Path.home() / ".cache" / "sglang" / "jit").resolve()) | ||
| assert create_runtime(lambda: os.environ.get("SGLANG_JIT_CACHE_DIR")) == expected | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.