Repository navigation
doc: add Spanish (es) documentation translations - #5112
Conversation
Bring in unified switcher.json, locale-aware navbar labels, and Read the Docs mo compilation helpers from feat/docs-i18n-de.
pt_BR and zh_TW catalogs fail when passed to Babel as pt-br/zh-tw; keep Sphinx locale folder names unchanged. Co-authored-by: Cursor <cursoragent@cursor.com>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request automates the compilation of translation catalogs (.po to .mo) for Sphinx documentation builds on Read the Docs and local environments. It introduces helper scripts for locale mapping and catalog compilation, updates the Sphinx configuration, and expands the documentation language switcher. The review feedback recommends improving robustness by handling the potential absence of the 'babel' library, simplifying the language resolution logic, and defensively modifying theme options using 'setdefault' to avoid potential KeyErrors.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
Detect missing babel up front and fall back to sphinx-intl for --all builds, and normalize explicit locale slugs consistently. Co-authored-by: Cursor <cursoragent@cursor.com>
|
/gemini review |
There was a problem hiding this comment.
Code Review
This pull request introduces a comprehensive internationalization (i18n) build system for the documentation, including a script to compile .po catalogs to .mo files, updated Makefile targets, ReadTheDocs integration, and Spanish translation catalogs. It also expands the language switcher to support ten languages and dynamically configures localized theme options in conf.py. The review feedback suggests several robustness improvements: handling English sub-locales (e.g., en-us) to prevent incorrect translation directory resolution, using .setdefault() to avoid a potential KeyError when configuring the version switcher, and wrapping the catalog compilation in a try...except block to prevent compilation failures from crashing local Sphinx builds.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
Normalize en-us/en-gb to English builds and use setdefault when updating the theme language switcher. Co-authored-by: Cursor <cursoragent@cursor.com>
|
/gemini review |
|
Warning Gemini encountered an error creating the review. You can try again by commenting |
|
Please review this pr @qinxuye .Thanks！ |
Catch mo compilation failures during conf import so missing tooling or bad catalogs do not abort Sphinx builds, use app.tags for zh_cn, and fix replica and XINFERENCE_LAUNCH_STRATEGY terminology in es and zh_CN launch docs. Co-authored-by: Cursor <cursoragent@cursor.com>
4 participants
Summary
Preview
Test plan
Made with Cursor