Skip to content

feat: new UI part 4 - #5040

Merged
qinxuye merged 23 commits into
xorbitsai:mainfrom
maoyuehui:feat-new-ui-version-4
Jun 18, 2026
Merged

qinxuye merged 23 commits into
xorbitsai:mainfrom
maoyuehui:feat-new-ui-version-4

Conversation

@maoyuehui

@maoyuehui maoyuehui commented Jun 16, 2026 •

Copy link
Copy Markdown
Collaborator
  1. Running model pages
  2. Runninf model detail pages
  3. Bug fix、run build fix
  4. request timeout control
  5. The sidebar supports expanding, collapsing, and grouping, menu permissions
  6. global add ui_config

@XprobeBot XprobeBot added this to the v2.x milestone Jun 16, 2026
@maoyuehui
maoyuehui requested a review from qinxuye June 16, 2026 09:16

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a comprehensive interactive capability workspace for running models, supporting features like chat, OCR, document parsing, and media generation. It also adds a collapsible sidebar, global UI configuration fetching, and reusable components like FileUpload and MediaPreview. The code review highlights several critical issues, including a blank page in the monitoring center when Grafana is configured, potential runtime crashes in the chat panel and error stream handling, a hardcoded private IP address in the API utility, memory leaks upon component unmount, and API validation failures caused by incorrect image size formatting (using * instead of x).

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread frontend/src/components/pages/monitor-center.tsx Outdated
Comment thread frontend/src/lib/utils.ts Outdated
Comment thread frontend/src/components/pages/running-model-detail/index.tsx Outdated
Comment thread frontend/src/components/pages/launch-model/utils.tsx Outdated
Comment thread frontend/src/components/pages/running-model-detail/utils.ts
Comment thread frontend/src/lib/eventStream.ts Outdated
@qinxuye qinxuye changed the title Feat: new UI version 4 feat: new UI part 4 Jun 16, 2026
@qinxuye

qinxuye commented Jun 16, 2026

Copy link
Copy Markdown
Contributor

/gemini review

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a comprehensive running model detail workspace, featuring interactive panels for capabilities like chat, OCR, document parsing, and media generation, alongside a collapsible sidebar and a new monitoring center page. The review feedback highlights several critical and high-severity issues: an XSS vulnerability in the markdown renderer due to unsanitized HTML parsing, a potential application crash in the chat panel caused by a race condition when clearing active streams, and buffer slicing and parsing bugs in the event stream helper. Additionally, improvements were suggested to address performance issues with large React keys, prevent broken route navigation, and simplify redundant ternary logic.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread frontend/src/components/ui/markdown-renderer.tsx
Comment thread frontend/src/components/pages/running-model-detail/panels/chat-panel.tsx Outdated
Comment thread frontend/src/lib/eventStream.ts Outdated
Comment thread frontend/src/lib/eventStream.ts Outdated
Comment thread frontend/src/components/pages/running-model-detail/panels/result-panels.tsx Outdated
Comment thread frontend/src/components/pages/running-model/index.tsx Outdated
Comment thread frontend/src/components/pages/running-model-detail/panels/chat-panel.tsx Outdated

@qinxuye qinxuye left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found one routing issue in the new sidebar entries.

Comment thread frontend/src/components/layout/sidebar.tsx Outdated

@qinxuye qinxuye left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found a few remaining issues in the current head.

Comment thread frontend/src/lib/eventStream.ts Outdated
Comment thread frontend/src/components/pages/running-model-detail/panels/chat-panel.tsx Outdated
Comment thread frontend/src/components/pages/running-model-detail/panels/chat-panel.tsx Outdated

@qinxuye qinxuye left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found one lockfile issue that blocks clean frontend installs.

Comment thread frontend/package.json

@qinxuye qinxuye left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The lockfile issue is fixed, but the new frontend still does not build cleanly.

Comment thread frontend/package.json

@qinxuye qinxuye left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@qinxuye
qinxuye merged commit a706b9d into xorbitsai:main Jun 18, 2026
6 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants