Skip to content

FEAT: [model] PaddleOCR-VL-1.6 support - #5033

Merged
qinxuye merged 4 commits into
xorbitsai:mainfrom
llyycchhee:chore/models-sync/user-llyycchhee/paddleocr-vl-1-6
Jun 18, 2026
Merged

qinxuye merged 4 commits into
xorbitsai:mainfrom
llyycchhee:chore/models-sync/user-llyycchhee/paddleocr-vl-1-6

Conversation

@llyycchhee

Copy link
Copy Markdown
Collaborator

Automated sync for model "PaddleOCR-VL-1.6" (image) by user llyycchhee.

@XprobeBot XprobeBot added this to the v2.x milestone Jun 15, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds a new model specification for PaddleOCR-VL-1.6 to the image model specifications. However, the model name will fail to match the existing OCR model class because the matching logic in the codebase strictly checks for PaddleOCR-VL. It is recommended to update the matching logic to support this new model version.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread xinference/model/image/model_spec.json
@llyycchhee

Copy link
Copy Markdown
Collaborator Author

/gemini review

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds support for the 'PaddleOCR-VL-1.6' model in the image model specifications and updates the matching logic in 'paddleocr_vl.py' to use a prefix-based match. The review feedback points out that using 'startswith' is too broad and suggests a safer matching logic to avoid false positives with other model names.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread xinference/model/image/ocr/paddleocr_vl.py Outdated

@qinxuye qinxuye left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@qinxuye
qinxuye merged commit 5a56807 into xorbitsai:main Jun 18, 2026
8 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants