Repository navigation
feat: new UI part 3 - #5011
feat: new UI part 3#5011
Conversation
There was a problem hiding this comment.
Code Review
This pull request introduces several UI enhancements and features, including a new RunningModel page, an updated model registration flow with edit support, and a refactored LaunchDialog featuring advanced configurations, command-line parsing, and configuration caching. Additionally, several UI components (Select, AutoComplete, Collapsible, Tooltip) were updated to support portal-based dropdowns and improved positioning. Key feedback points out a missing 'use client' directive in custom-edit-dialog.tsx, a hardcoded private IP fallback in utils.ts, an incorrect loading state variable in the replica deletion dialog within running-model/index.tsx, and a potential SyntaxError when parsing modelStr in register-model/index.tsx.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
|
/gemini review |
There was a problem hiding this comment.
Code Review
This pull request introduces several enhancements to the model launching and registration interface, including a new running models management page, advanced configuration options, command-line statement generation, and configuration caching. It also refactors several UI components like Select, AutoComplete, and Tooltip to support portal-based dropdown positioning and custom values. The code review identified several critical issues: a missing dependency in a useMemo hook in custom-edit-dialog.tsx, a missing safety check for deleteModel in handleDeleteModel, premature polling termination on transient errors in fetchProgress, the use of a non-existent Lucide icon (CircleQuestionMark) in tooltip.tsx, and an unconditional reset of the active model selection on list refresh in running-model/index.tsx.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
…d replicas, first retrieve the model_uid. If it cannot be retrieved, then retrieve the model_name
Model Deploy
Register Model
Form Compontens
Running Model Page