Skip to content

feat: new UI part 3 - #5011

Merged
qinxuye merged 11 commits into
xorbitsai:mainfrom
maoyuehui:feat-new-ui-version-3
Jun 10, 2026
Merged

qinxuye merged 11 commits into
xorbitsai:mainfrom
maoyuehui:feat-new-ui-version-3

Conversation

@maoyuehui

@maoyuehui maoyuehui commented Jun 9, 2026 •

Copy link
Copy Markdown
Collaborator

Model Deploy

  1. Seven Model Type Forms, Progress Tracking, and Cancel
  2. Custom Model Delete and Edit
  3. Cache Config
  4. Copy Command Line and Parse Command Line

Register Model

  1. Refactored Model Registration from a Single Route to Dynamic Routes
  2. Added Model Registration Edit Page
  3. Added Copy for JSON view

Form Compontens

  1. Support for Hidden Form Fields

Running Model Page

@XprobeBot XprobeBot added this to the v2.x milestone Jun 9, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces several UI enhancements and features, including a new RunningModel page, an updated model registration flow with edit support, and a refactored LaunchDialog featuring advanced configurations, command-line parsing, and configuration caching. Additionally, several UI components (Select, AutoComplete, Collapsible, Tooltip) were updated to support portal-based dropdowns and improved positioning. Key feedback points out a missing 'use client' directive in custom-edit-dialog.tsx, a hardcoded private IP fallback in utils.ts, an incorrect loading state variable in the replica deletion dialog within running-model/index.tsx, and a potential SyntaxError when parsing modelStr in register-model/index.tsx.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread frontend/src/components/pages/launch-model/custom-edit-dialog.tsx
Comment thread frontend/src/lib/utils.ts Outdated
Comment thread frontend/src/components/pages/running-model/index.tsx Outdated
Comment thread frontend/src/components/pages/register-model/index.tsx
@maoyuehui

Copy link
Copy Markdown
Collaborator Author

/gemini review

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces several enhancements to the model launching and registration interface, including a new running models management page, advanced configuration options, command-line statement generation, and configuration caching. It also refactors several UI components like Select, AutoComplete, and Tooltip to support portal-based dropdown positioning and custom values. The code review identified several critical issues: a missing dependency in a useMemo hook in custom-edit-dialog.tsx, a missing safety check for deleteModel in handleDeleteModel, premature polling termination on transient errors in fetchProgress, the use of a non-existent Lucide icon (CircleQuestionMark) in tooltip.tsx, and an unconditional reset of the active model selection on list refresh in running-model/index.tsx.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread frontend/src/components/pages/launch-model/custom-edit-dialog.tsx Outdated
Comment thread frontend/src/components/pages/launch-model/index.tsx
Comment thread frontend/src/components/ui/tooltip.tsx
Comment thread frontend/src/components/ui/tooltip.tsx
Comment thread frontend/src/components/pages/running-model/index.tsx
@qinxuye qinxuye changed the title Feat: new UI version 3 feat: new UI version 3 Jun 9, 2026
Comment thread frontend/src/components/pages/launch-model/launch-dialog/launch-dialog.tsx Outdated
@qinxuye qinxuye changed the title feat: new UI version 3 feat: new UI part 3 Jun 9, 2026
…d replicas, first retrieve the model_uid. If it cannot be retrieved, then retrieve the model_name

@qinxuye qinxuye left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@qinxuye
qinxuye merged commit b4bfcfd into xorbitsai:main Jun 10, 2026
10 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants