Add exact bounds support to ind_lim_vrange_dialog - #282
Open
michaellans wants to merge 8 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added support for specifying exact bounds in the ind_lim_vrange_dialog. This is done by adding logic for a fourth option
option_idx == 3to the bounds options dictionary, and adding that option to the bounds scaling/calculation logic. This allows setting relative/exact bounds independently for each variable, rather than a global relative_to_current settingAdded a new "exact_bounds" option to variable range selection dialog, with spinboxes for typing in bounds
Updated the bounds scaling calculation and auto-bounds logic to handle "exact_bounds". I also added this to the main GUI routine_page, as the
ind_lim_vrange_dialogis sharedAlso updated the dialog to display current bounds below the current value.
Tested setting/saving
exact_boundswith templates, this worked well without needing further changesSimplified tooltips for when bounds are clipped.