ci: run Lint workflow on Node 20 - #432
Merged
Merged
Conversation
The package requires node >=20, but the Lint workflow (sourced from the default branch on pull_request_target) pinned Node 16, so npm ci failed with EBADENGINE. Bump setup-node/checkout and the Node version to 20.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
Lintworkflow (.github/workflows/eslint.yml) is sourced from the default branch (master) onpull_request_target, and still pins Node 16. The package requiresengines.node >= 20, sonpm cifails withEBADENGINEon every PR (e.g. #431).This bumps the workflow to Node 20 and updates
actions/checkoutandactions/setup-nodeto v4 (matching whatnextalready uses), which clears the failing install step.Fixes the failing ES Lint check on open PRs.