Skip to content

Added: lookup8 in VX4B using vlookup - #225

Open
LeslieXMOS wants to merge 2 commits into
xmos:developfrom
LeslieXMOS:feature/lookup8_quake
Open

Added: lookup8 in VX4B using vlookup#225
LeslieXMOS wants to merge 2 commits into
xmos:developfrom
LeslieXMOS:feature/lookup8_quake

Conversation

@LeslieXMOS

Copy link
Copy Markdown
Contributor

Implemented lookup8 in VX4B using the new VPU instruction xm.vlookup.
Tested with custom model, output is the same as the ref.

@McCrea McCrea left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Most of these are just stylistic, but some observations on the RISC-V ASM.

Comment thread lib_nn/src/asm/lookup8.S Outdated
Comment thread lib_nn/src/asm/lookup8.S Outdated
Comment thread lib_nn/src/asm/lookup8.S Outdated
Comment thread lib_nn/src/asm/lookup8.S Outdated
Comment thread lib_nn/src/asm/lookup8.S Outdated
Comment thread lib_nn/src/asm/lookup8.S Outdated
Comment thread lib_nn/src/asm/lookup8.S Outdated
Comment thread lib_nn/src/asm/lookup8.S Outdated
@xross

xross commented Aug 12, 2026

Copy link
Copy Markdown
Contributor

Where PR's for a feature have become multiple commits during a review cycle please consider squashing

Co-authored-by: Jack McCrea <automccrea@icloud.com>

Removed unnecessary nop; Refactor to be more idiomatic

Packetize instruction to increase speed
@LeslieXMOS
LeslieXMOS force-pushed the feature/lookup8_quake branch from 05ef7b7 to d6c36ac Compare August 12, 2026 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants