Skip to content

cltest: share one go-build cache across captured runs #2035

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
cpunion wants to merge 1 commit into
base: main
Choose a base branch
from
+17 −2
Open

cltest: share one go-build cache across captured runs #2035

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 17 additions & 2 deletions cl/cltest/cltest.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,7 @@ import (
"runtime"
"slices"
"strings"
"sync"
"testing"

"github.com/goplus/gogen/packages"
Expand Down Expand Up @@ -313,6 +314,21 @@ func testRunAndTestFrom(t *testing.T, pkgDir, relPkg, sel string, opts runOption
}
}

// sharedGoCacheDir returns a per-process go-build cache reused by every
// captured run. Isolation from the developer cache is preserved (fresh
// temp dir per test process); sharing across tests avoids re-typechecking
// the whole dependency graph for each of the ~170 golden dirs.
var goCacheOnce sync.Once
var goCacheDir string
var goCacheErr error

func sharedGoCacheDir() (string, error) {
goCacheOnce.Do(func() {
goCacheDir, goCacheErr = os.MkdirTemp("", "llgo-gocache-*")
})
return goCacheDir, goCacheErr
}

func RunAndCapture(relPkg, pkgDir string) ([]byte, error) {
conf := build.NewDefaultConf(build.ModeRun)
return RunAndCaptureWithConf(relPkg, pkgDir, conf)
Expand Down Expand Up @@ -376,11 +392,10 @@ func runWithConf(relPkg, pkgDir string, conf *build.Config) ([]byte, error) {
}

func doWithConf(relPkg, pkgDir string, conf *build.Config, action string) ([]byte, error) {
cacheDir, err := os.MkdirTemp("", "llgo-gocache-*")
cacheDir, err := sharedGoCacheDir()
if err != nil {
return nil, err
}
defer os.RemoveAll(cacheDir)
oldCache := os.Getenv("GOCACHE")
if err := os.Setenv("GOCACHE", cacheDir); err != nil {
return nil, err
Expand Down
Loading