runtime: use hchan-style channel queues#2030
Open
zhouguangyuan0718 wants to merge 1 commit into
Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
297fbdb to
90e6402
Compare
90e6402 to
5130dae
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Design Notes
Channow tracksqcount/dataqsiz/buf/recvx/sendxplussendqandrecvq.chanWaiterand sleep on a condvar.waitStatusstate machine instead of separatedone,recvOK,panicOnWake, andclaimedbooleans.waitClaimedkeeps select two-phase completion safe: a case can reserve the select result before copying data, and only the final status wakes the select goroutine.selectState.[selectInlineChanCount]*Chanand spills to a slice when a select references more distinct channels.Tests
/opt/data/tmp/llgo-pr-split/llgo-channel test -timeout=180s ./test -run 'Test(ClosedChannelSendPanicDoesNotKeepChannelLocked|SelectDuplicateChannelDoesNotDeadlock|ConcurrentSelectProposeReplyStress)' -count=1Added Coverage