fix(dashboards): cap embedded table height via config.height#45
Merged
Conversation
A dashboard TableTabs defaults to grow-with-rows (config.height unset), so a big list (hundreds of orders) expands endlessly and pushes the rest of the cockpit off the page — even alone in its column it starts ~25 rows tall. The widget already supports a bound (config.height: '420px' = compact preset → ~8 rows, then internal scroll via stylesFromHeight); nothing was setting it. - warehouse_shipping dashboard: set the backlog table to '420px'. - xentral-dashboards skill (widgets.md + SKILL.md): correct the table-height rule — lead with config.height instead of the earlier 'no row cap / narrow with a status filter' advice, which missed the shipped mechanism and didn't actually bound the height. - shopify-warehouse prompt: instruct compact table height explicitly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The logistics/warehouse dashboard embedded an order table (
TableTabs) that grows endlessly. The embedded workspace view paginates at 25/page, but withconfig.heightunset the widget defaults to grow-with-rows — so it starts ~25 rows tall and keeps growing, pushing the rest of the cockpit off the page.Root cause
Not a missing capability: the widget already supports a bounded height.
stylesFromHeight('420px')→{ height: '420px', overflow: 'auto' }, and the editor exposes it as the compact preset ("~8 rows, then scrolls internally"). Nothing was setting it, and my earlier skill rule (#42) wrongly saidTableTabshas "no row cap" and pointed at a status filter — which reduces rows but does not bound height.Fix (uses the shipped mechanism, no new CSS)
warehouse_shippingdashboard — backlog table set toconfig.height: "420px".config.height("420px"compact /"fill"); note a status filter alone does not cap height.Supersedes the guidance in #42.