Repository navigation
Conversation
Prevent global keyboard shortcuts from being registered when components are rendered in a preview context. Previously, mounting the slide controller or projection queue unconditionally bound the 0-9 keys, causing unexpected side effects and shortcut conflicts within previews. To resolve this, the registration now respects the preview state: - Added an early return guard in the registration hooks if `isPreview` is active. - Included `isPreview` in the effect dependency arrays to ensure proper cleanup and lifecycle management.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Prevents global keyboard shortcuts from being registered when components are rendered in a preview context, resolving unexpected behavior and shortcut conflicts.
Key Changes
🐛 Bug Fixes
isPreviewstate is active.isPreviewin effect dependency arrays to ensure proper lifecycle management and cleanup.Version Bump
0.0.1