Skip to content

core: (attr assembly fmt) add keyword directive#6249

Open
n-io wants to merge 2 commits into
mainfrom
nicolai/attr-asm-fmt-keyword-directive
Open

core: (attr assembly fmt) add keyword directive#6249
n-io wants to merge 2 commits into
mainfrom
nicolai/attr-asm-fmt-keyword-directive

Conversation

@n-io

@n-io n-io commented Jul 13, 2026

Copy link
Copy Markdown
Collaborator

Adds AttrKeywordDirective to declarative assembly format for attributes.

WIP:

@n-io n-io self-assigned this Jul 13, 2026
@n-io n-io added the core xDSL core (ir, textual format, ...) label Jul 13, 2026
@n-io n-io requested a review from superlopuh July 13, 2026 19:38
@codecov

codecov Bot commented Jul 13, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.90%. Comparing base (e603030) to head (c067d24).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6249   +/-   ##
=======================================
  Coverage   86.89%   86.90%           
=======================================
  Files         431      431           
  Lines       64628    64642   +14     
  Branches     7402     7403    +1     
=======================================
+ Hits        56161    56176   +15     
  Misses       6896     6896           
+ Partials     1571     1570    -1     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Comment on lines +61 to +70
@pytest.mark.parametrize(
"format_str, printed",
[("`hello`", "hello"), ("`foo``bar`", "foo bar")],
)
def test_keyword_print(format_str: str, printed: str):
assert _print(format_str) == printed


def test_keyword_parse():
assert _parse("`kw`", "kw") == []

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's add this to the tests above

@n-io n-io requested a review from superlopuh July 14, 2026 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core xDSL core (ir, textual format, ...)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants