dialects: split bitmanipulation ops in rv32 and rv64#6239
Open
luisacicolini wants to merge 6 commits into
Open
dialects: split bitmanipulation ops in rv32 and rv64#6239luisacicolini wants to merge 6 commits into
luisacicolini wants to merge 6 commits into
Conversation
luisacicolini
requested review from
osmanyasar05 and
superlopuh
and removed request for
superlopuh
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6239 +/- ##
==========================================
- Coverage 86.90% 86.87% -0.03%
==========================================
Files 431 431
Lines 64642 64682 +40
Branches 7403 7403
==========================================
+ Hits 56174 56194 +20
- Misses 6897 6917 +20
Partials 1571 1571 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
superlopuh
reviewed
Jun 30, 2026
| name = "rv32.bclri" | ||
|
|
||
| def py_operation(self, rs1: IntegerAttr[I32]) -> IntegerAttr[I32]: | ||
| assert isinstance(self.immediate, IntegerAttr) |
Member
There was a problem hiding this comment.
can you please add tests for this and below?
Collaborator
Author
|
thank you @superlopuh for the review, all addressed :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Split the riscv operations from the B standard extension with different immediates' width depending on the architecture's bit-width (rv32 or rv64).
The involved ops are
bclri,binvi,bseti,rori,bexti.