canonicalization and removal of redundant moves#6227
Draft
luisacicolini wants to merge 4 commits into
Draft
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6227 +/- ##
=======================================
Coverage 86.88% 86.88%
=======================================
Files 431 432 +1
Lines 64559 64575 +16
Branches 7395 7396 +1
=======================================
+ Hits 56090 56105 +15
- Misses 6897 6898 +1
Partials 1572 1572 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
superlopuh
reviewed
Jun 29, 2026
| PatternRewriteWalker( | ||
| GreedyRewritePatternApplier( | ||
| [ | ||
| RemoveUnusedOperations(), |
Member
There was a problem hiding this comment.
should not be necessary, does this not work without it?
superlopuh
reviewed
Jun 29, 2026
| RemoveRedundantFMvD(), | ||
| ] | ||
| ), | ||
| post_walk_func=region_dce, |
superlopuh
reviewed
Jun 29, 2026
Comment on lines
+52
to
+54
| # reuse source register type to allow redundant mv elimination | ||
| phys_reg = inner_op.rs.type | ||
| phys_reg_by_inf_reg[result_reg] = phys_reg |
Member
There was a problem hiding this comment.
The point is actually not to do this, and instead do it in a different coalescing phase that's not yet merged, so this is not a good change for this pass.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Template
Please add a short description of your changes, and the motivation behind them.
Make sure your PR title follows the guidelines