Skip to content

core: (attr assembly fmt) add custom directive (pt7)#5906

Open
n-io wants to merge 1 commit into
nicolai/attr-asm-fmt-pt6-struct-v2from
nicolai/attr-asm-fmt-pt7-custom-v2
Open

core: (attr assembly fmt) add custom directive (pt7)#5906
n-io wants to merge 1 commit into
nicolai/attr-asm-fmt-pt6-struct-v2from
nicolai/attr-asm-fmt-pt7-custom-v2

Conversation

@n-io

@n-io n-io commented Apr 21, 2026

Copy link
Copy Markdown
Collaborator

Add AttrCustomDirective ABC and irdl_attr_custom_directive decorator for user-defined assembly format directives in attribute/type formats, mirroring the existing CustomDirective system for operations.

Add AttrCustomDirective ABC and irdl_attr_custom_directive decorator
for user-defined assembly format directives in attribute/type formats,
mirroring the existing CustomDirective system for operations.
@n-io n-io self-assigned this Apr 21, 2026
@n-io n-io added the core xDSL core (ir, textual format, ...) label Apr 21, 2026
@n-io n-io changed the title core: (attr assembly fmt) add custom directive core: (attr assembly fmt) add custom directive (pt7) Apr 21, 2026
@codecov

codecov Bot commented Apr 21, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 71.87500% with 9 lines in your changes missing coverage. Please review.
✅ Project coverage is 86.22%. Comparing base (0bebfa9) to head (c9c895c).

Files with missing lines Patch % Lines
xdsl/irdl/declarative_assembly_format_parser.py 73.68% 2 Missing and 3 partials ⚠️
xdsl/irdl/declarative_assembly_format.py 69.23% 2 Missing and 2 partials ⚠️
Additional details and impacted files
@@                          Coverage Diff                           @@
##           nicolai/attr-asm-fmt-pt6-struct-v2    #5906      +/-   ##
======================================================================
- Coverage                               86.22%   86.22%   -0.01%     
======================================================================
  Files                                     418      418              
  Lines                                   60265    60297      +32     
  Branches                                 7002     7010       +8     
======================================================================
+ Hits                                    51966    51990      +24     
- Misses                                   6691     6695       +4     
- Partials                                 1608     1612       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core xDSL core (ir, textual format, ...)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant