Skip to content

core: (attr assembly fmt) add optional group directive (pt3)#5902

Open
n-io wants to merge 1 commit into
nicolai/attr-asm-fmt-pt2-integrationfrom
nicolai/attr-asm-fmt-pt3-optional-groups-v2
Open

core: (attr assembly fmt) add optional group directive (pt3)#5902
n-io wants to merge 1 commit into
nicolai/attr-asm-fmt-pt2-integrationfrom
nicolai/attr-asm-fmt-pt3-optional-groups-v2

irdl: add optional group support for attr assembly format

d122c60
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Apr 21, 2026 in 0s

86.22% (target 1.00%)

View this Pull Request on Codecov

86.22% (target 1.00%)

Details

Codecov Report

❌ Patch coverage is 72.58065% with 17 lines in your changes missing coverage. Please review.
✅ Project coverage is 86.22%. Comparing base (875f177) to head (d122c60).

Files with missing lines Patch % Lines
xdsl/irdl/declarative_assembly_format_parser.py 61.29% 5 Missing and 7 partials ⚠️
xdsl/irdl/declarative_assembly_format.py 83.87% 5 Missing ⚠️
Additional details and impacted files
@@                           Coverage Diff                            @@
##           nicolai/attr-asm-fmt-pt2-integration    #5902      +/-   ##
========================================================================
+ Coverage                                 86.21%   86.22%   +0.01%     
========================================================================
  Files                                       418      418              
  Lines                                     60104    60166      +62     
  Branches                                   6955     6977      +22     
========================================================================
+ Hits                                      51818    51878      +60     
+ Misses                                     6688     6685       -3     
- Partials                                   1598     1603       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.