core: (attr assembly fmt) add wiring into irdl_param_attr_def (pt2)#5901
Open
n-io wants to merge 2 commits into
Open
core: (attr assembly fmt) add wiring into irdl_param_attr_def (pt2)#5901n-io wants to merge 2 commits into
n-io wants to merge 2 commits into
Conversation
Add the foundational classes for a declarative assembly format system for ParametrizedAttribute types, mirroring the existing op-side system: AttrFormatDirective ABC, structural directives (whitespace, punctuation, keyword), ParameterVariable, AttrFormatProgram, and AttrFormatParser.
…nition Integrate the attr declarative assembly format into the attribute definition system. ParametrizedAttribute subclasses can now set assembly_format = "..." to auto-generate parse_parameters and print_parameters methods.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## nicolai/attr-asm-fmt-pt1-core-directives #5901 +/- ##
=========================================================================
Coverage 86.20% 86.21%
=========================================================================
Files 418 418
Lines 60077 60104 +27
Branches 6950 6955 +5
=========================================================================
+ Hits 51791 51818 +27
+ Misses 6689 6688 -1
- Partials 1597 1598 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
n-io
changed the title
n-io
changed the title
n-io
force-pushed
the
nicolai/attr-asm-fmt-pt1-core-directives
branch
from
377ba90 to
b8e73f1
Compare
Member
|
Happy to review this as soon as merge conflicts are resolved. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Integrate the attr declarative assembly format into the attribute definition system. ParametrizedAttribute subclasses can now set assembly_format = "..." to auto-generate parse_parameters and print_parameters methods.
Stacked on top of: #5900