Skip to content

[WIP] transforms: (func-inline) add prototype#5844

Open
alexarice wants to merge 1 commit into
mainfrom
alexarice/inline
Open

[WIP] transforms: (func-inline) add prototype#5844
alexarice wants to merge 1 commit into
mainfrom
alexarice/inline

Conversation

@alexarice

Copy link
Copy Markdown
Collaborator

wip for a simple xdsl function inliner.
Probably needs:

  • tests
  • some recursion check

but I would like to check that this is a desirable feature in this form before I commit to doing more work

@alexarice alexarice requested a review from superlopuh April 16, 2026 11:07
@alexarice alexarice self-assigned this Apr 16, 2026
@alexarice alexarice added the transformations Passes, rewrites label Apr 16, 2026
@codecov

codecov Bot commented Apr 16, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 44.44444% with 20 lines in your changes missing coverage. Please review.
✅ Project coverage is 86.83%. Comparing base (a80e61f) to head (2a23f6f).

Files with missing lines Patch % Lines
xdsl/transforms/func_inline.py 39.39% 20 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5844      +/-   ##
==========================================
- Coverage   86.85%   86.83%   -0.03%     
==========================================
  Files         428      429       +1     
  Lines       64249    64285      +36     
  Branches     7368     7371       +3     
==========================================
+ Hits        55804    55820      +16     
- Misses       6880     6900      +20     
  Partials     1565     1565              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@superlopuh

Copy link
Copy Markdown
Member

It would be pretty great to have something that looks a little bit more like the MLIR inliner, do you have any motivation for this?

@alexarice

Copy link
Copy Markdown
Collaborator Author

I do not

@alexarice

Copy link
Copy Markdown
Collaborator Author

I just want to bump this because this is still a feature that I would like to have and I would prefer to have some way to do this than no way to do it.

@superlopuh

Copy link
Copy Markdown
Member

Fair enough, I think I overcommitted here. I would rather have it only work on things when we're sure that it's correct, though. As it stands it seems too aggressive to me, and would inline more things than MLIR would. Could you please take a look at the MLIR definition and add any checks necessary to be sure that we have a strict subset of the functionality upstream?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

transformations Passes, rewrites

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants