[WIP] transforms: (func-inline) add prototype#5844
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5844 +/- ##
==========================================
- Coverage 86.85% 86.83% -0.03%
==========================================
Files 428 429 +1
Lines 64249 64285 +36
Branches 7368 7371 +3
==========================================
+ Hits 55804 55820 +16
- Misses 6880 6900 +20
Partials 1565 1565 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
It would be pretty great to have something that looks a little bit more like the MLIR inliner, do you have any motivation for this? |
|
I do not |
|
I just want to bump this because this is still a feature that I would like to have and I would prefer to have some way to do this than no way to do it. |
|
Fair enough, I think I overcommitted here. I would rather have it only work on things when we're sure that it's correct, though. As it stands it seems too aggressive to me, and would inline more things than MLIR would. Could you please take a look at the MLIR definition and add any checks necessary to be sure that we have a strict subset of the functionality upstream? |
baf8e2c to
2a23f6f
Compare
wip for a simple xdsl function inliner.
Probably needs:
but I would like to check that this is a desirable feature in this form before I commit to doing more work