Skip to content

Add "Select" button mapping for Amiga CD32 controller#340

Merged
garbear merged 1 commit into
xbmc:Piersfrom
garbear:amiga-select
May 11, 2026
Merged

Add "Select" button mapping for Amiga CD32 controller#340
garbear merged 1 commit into
xbmc:Piersfrom
garbear:amiga-select

Conversation

@garbear

@garbear garbear commented May 11, 2026

Copy link
Copy Markdown

Description

Part of "Amiga Input Refinement" epic.

This adds the additional "Select" button on the Amiga CD32 controller to the default map for XInput controllers on Windows. The button mapper applies it to every other platform.

Motivation and context

Requested here: kodi-game/game.libretro.uae#11

Related PRs

Amiga Input Tuning:

@kodiai

kodiai Bot commented May 11, 2026

Copy link
Copy Markdown

Decision: APPROVE

kodiai response

Decision: APPROVE
Issues: none

Evidence:

  • Review prompt covered 1 changed file.
Review Details
  • Review plan: ready hash=177780439777 route=tiny-diff task=review.small-diff files=1 lines=1(local-diff) budget=25t/518s gates=3/3 publish=canonical-visible-surface graph=skipped candidates=preferred

  • Review reducer: ready input=0 kept=0 suppressed=0 rewritten=0 deprioritized=0 lowConfidence=0 auditEvents=0 severityDemoted=0 graphValidated=0 graphUncertain=0

  • Review candidates: shadow recorded=0 rejected=0 errors=0 artifact=absent repo=xbmc-peripheral.joystick pr=340 key=kodiai-review-output:v1:inst-109141824:xbmc-peripheral.joystick:pr-340:action-op delivery=411e5910-4d01-11f1-839e-dfbea4868307

  • Review candidate publication: mode=blocked approved=0 rewritten=0 published=0 directFallback=0 reasons=no-candidate-publication-path,approval-blocked

  • Files reviewed: 1

  • Findings: 0 critical, 0 major, 0 medium, 0 minor

  • Lines changed: +1 -0

  • Profile: strict (auto, lines changed: 1)

  • Contributor experience: profile-backed (using linked contributor profile guidance)

  • Review completed: 2026-05-11T06:20:33.159Z

  • Total wall-clock: 1m 51s

  • Phase timings:

    • queue wait: 0ms
    • workspace preparation: 910ms
    • retrieval/context assembly: 3.4s
    • executor handoff: 16s
    • remote runtime: 1m 25s
    • publication: 3.1s
  • Claude Code usage: 15% of seven_day limit remaining | resets 2026-05-13T02:00:00.000Z

  • Tokens: 26 in / 2,113 out | 0.1072

  • Keyword parsing: No keywords detected

@garbear

garbear commented May 11, 2026

Copy link
Copy Markdown
Author

Confirmed working in kodi-game/game.libretro.uae#11

@garbear garbear merged commit e3befcf into xbmc:Piers May 11, 2026
9 checks passed
@garbear garbear deleted the amiga-select branch May 11, 2026 23:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant