feat: detect a missing jstsToken cookie without hitting Babelio - #38
Merged
Conversation
Distinguish "no cookie configured" from "cookie rejected" (BabelioTokenMissing vs BabelioBlocked) so search/cover requests fail fast with an actionable message instead of tripping the circuit breaker on a request that was never going to succeed. Centralize the error-to-message mapping in message_for_error() so identify(), _run_workers(), and download_cover() stay in sync.
xballoy
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
jstsTokencookie is left blank in the plugin settings, searches and cover downloads now fail immediately with a clear "no cookie configured" message instead of sending a request to Babelio that was always going to be rejected.Test plan
uv run --python 3.13 pytest— full suite passes, 100% coverageuv run mypyanduv run ruff check— clean