Remove ResourceNaming libraries migrated to their own repository - #24
Merged
Conversation
Trellis.ResourceNaming.Abstractions and Trellis.ResourceNaming.Azure now live in xavierjohn/Trellis.ResourceNaming and ship from there (0.1.0-preview.12 on nuget.org). This repository keeps only the two dotnet new templates, so the migrated sources and their publishing pipeline are removed here. Deleted: - src/ (both library projects, their tests, props and solution) - build/Trellis.ApiReference.targets and build/test-apireference-packaging.ps1 - docs/api_reference/ (moved with the libraries) - .github/workflows/libraries.yml, publish-libraries.yml, publish-libraries-github.yml Both templates already consume Trellis.ResourceNaming.Azure as a published package rather than by ProjectReference, so template build and contract checks are unaffected. The four required checks (build/contract for asp and microservices) come from build-templates.yml and contract-parity.yml, which are untouched. Kept deliberately: - shared/conventions/resource-naming.md, a cross-template convention doc linked from the new repository's package README - asp/template/Acl/tests/ResourceNamingLibraryTests.cs, a template consumer test that exercises the published package Also drops the now-moot api_reference/** docfx exclusion and points the README's related-projects list at the new repository.
There was a problem hiding this comment.
Pull request overview
This PR removes the Trellis.ResourceNaming.* library source (and its supporting build/docs/CI plumbing) from this repository after migrating it to a dedicated repo, returning this codebase to being focused on the two dotnet new templates.
Changes:
- Deleted the
src/ResourceNaming solution/projects and their unit tests, plus related packaging/gating scripts and workflows. - Removed the ResourceNaming API reference doc and the now-unneeded DocFX exclude entry that only applied to it.
- Updated the root README to link to the new
xavierjohn/Trellis.ResourceNamingrepository.
Reviewed changes
Copilot reviewed 32 out of 32 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
src/Trellis.ResourceNaming.slnx |
Removed migrated ResourceNaming solution. |
src/Directory.Build.props |
Removed library-only build/package properties. |
src/Trellis.ResourceNaming.Abstractions/Trellis.ResourceNaming.Abstractions.csproj |
Removed migrated Abstractions package project. |
src/Trellis.ResourceNaming.Abstractions/IResourceNamer.cs |
Removed migrated library code. |
src/Trellis.ResourceNaming.Abstractions/NamingRequest.cs |
Removed migrated library code. |
src/Trellis.ResourceNaming.Abstractions/ResourceTypeSpec.cs |
Removed migrated library code. |
src/Trellis.ResourceNaming.Abstractions/NameSeparator.cs |
Removed migrated library code. |
src/Trellis.ResourceNaming.Abstractions/CloudScope.cs |
Removed migrated library code. |
src/Trellis.ResourceNaming.Abstractions/NamingPolicy.cs |
Removed migrated library code. |
src/Trellis.ResourceNaming.Abstractions/ResourceNameOverflowException.cs |
Removed migrated library code. |
src/Trellis.ResourceNaming.Azure/Trellis.ResourceNaming.Azure.csproj |
Removed migrated Azure package project. |
src/Trellis.ResourceNaming.Azure/README.md |
Removed migrated package README. |
src/Trellis.ResourceNaming.Azure/AzureResourceNamer.cs |
Removed migrated library code. |
src/Trellis.ResourceNaming.Azure/AzureResourceTypes.cs |
Removed migrated library code. |
src/Trellis.ResourceNaming.Azure/AzureEndpoints.cs |
Removed migrated library code. |
src/Trellis.ResourceNaming.Azure/AzureClouds.cs |
Removed migrated library code. |
src/Trellis.ResourceNaming.Azure/CloudEndpoints.cs |
Removed migrated library code. |
src/Trellis.ResourceNaming.Azure/KnownClouds.cs |
Removed migrated library code. |
src/Trellis.ResourceNaming.Azure/DeployedEnvironmentOptions.cs |
Removed migrated library code. |
src/Trellis.ResourceNaming.Azure/DeployedEnvironmentOptionsExtensions.cs |
Removed migrated library code. |
src/Trellis.ResourceNaming.Azure.Tests/Trellis.ResourceNaming.Azure.Tests.csproj |
Removed migrated unit test project. |
src/Trellis.ResourceNaming.Azure.Tests/AzureResourceNamerTests.cs |
Removed migrated tests. |
src/Trellis.ResourceNaming.Azure.Tests/AzureEndpointsTests.cs |
Removed migrated tests. |
src/Trellis.ResourceNaming.Azure.Tests/DeployedEnvironmentOptionsTests.cs |
Removed migrated tests. |
docs/api_reference/trellis-api-resourcenaming.md |
Removed API reference doc that moved with the library. |
docs/docfx.json |
Dropped api_reference/** exclusion now that the folder is removed. |
build/Trellis.ApiReference.targets |
Removed library packaging copy-logic file (no longer needed here). |
build/test-apireference-packaging.ps1 |
Removed library packaging gate script (moved with library). |
.github/workflows/libraries.yml |
Removed library build/test workflow. |
.github/workflows/publish-libraries.yml |
Removed library publish workflow (nuget.org). |
.github/workflows/publish-libraries-github.yml |
Removed library publish workflow (GitHub Packages). |
README.md |
Added link to the new ResourceNaming repository in related projects. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Removes the
Trellis.ResourceNaming.*libraries from this repository. They now live in xavierjohn/Trellis.ResourceNaming and ship from there —0.1.0-preview.12is published on nuget.org.This repository goes back to being just the two
dotnet newtemplates.Deleted
src/Directory.Build.props, and the solution — all migratedbuild/Trellis.ApiReference.targets,build/test-apireference-packaging.ps1docs/api_reference/trellis-api-resourcenaming.md, moved with the libraries.github/workflows/libraries.yml,publish-libraries.yml,publish-libraries-github.ymlAlso removes the now-moot
api_reference/**entry from the docfx exclude list, and adds the new repository to the README's related-projects list.Kept deliberately
shared/conventions/resource-naming.md— a cross-template convention doc, and the new repository's package README links to it at its github.com URL.asp/template/Acl/tests/ResourceNamingLibraryTests.cs— a template consumer test that exercises the published package.Why this is safe
ProjectReferenceinto the deletedsrc/. Both consumeTrellis.ResourceNaming.Azureas aPackageVersionfrom nuget.org, so template restore and build are unaffected.build (asp),build (microservices),contract (asp),contract (microservices)— are produced bybuild-templates.ymlandcontract-parity.yml, both untouched. Neither has apaths:filter, so both still run on every PR..gitignore).Follow-up (not in this PR)
Both templates still pin
Trellis.ResourceNaming.Azureat0.1.0-preview.1. Bumping them to0.1.0-preview.12is a separate change.