Skip to content

Fix clippy nonminimal_bool lint causing windows-latest CI failure - #1

Merged
xandwrp merged 2 commits into
mainfrom
copilot/fix-github-actions-job
Aug 23, 2026
Merged

xandwrp merged 2 commits into
mainfrom
copilot/fix-github-actions-job

Conversation

Copilot AI commented Aug 23, 2026 •

Copy link
Copy Markdown
Contributor

The windows-latest / Rust 1.85.0 CI job was failing because cargo clippy -D warnings rejected a triple-negation boolean expression under the nonminimal_bool lint.

Change

Rewrote the condition in src/inventory.rs from three separate negated terms joined by && into an equivalent single-negated || expression:

// Before
if !Path::new(identity).is_absolute()
    && !identity.starts_with("~/")
    && !(cfg!(windows) && identity.starts_with("~\\"))

// After
if !(Path::new(identity).is_absolute()
    || identity.starts_with("~/")
    || cfg!(windows) && identity.starts_with("~\\"))

No semantic change — purely satisfies clippy's canonical form requirement.

Co-authored-by: xandwr <94504311+xandwr@users.noreply.github.com>
Copilot AI changed the title [WIP] Fix the failing GitHub Actions job windows-latest / Rust 1.85.0 Fix clippy nonminimal_bool lint causing windows-latest CI failure Aug 23, 2026
Copilot AI requested a review from xandwrp August 23, 2026 01:55
@xandwrp
xandwrp marked this pull request as ready for review August 23, 2026 01:55
@xandwrp
xandwrp merged commit c0db5a9 into main Aug 23, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants