Repository navigation
fix: accept Vision ACME without explicit plain MIME type - #29
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Vision HTTP-01 vhost emitted by 3X-UI AUTO NGINX omits
default_type text/plain, so manager WEB planning succeeds but ACME planning refuses an otherwise recognized safe topology. Allow that directive to be absent; when present it must still be exactlytext/plain, once. Required root/try_files, exact locations/listeners, domain conflicts and all other restrictions remain intact.Production changes only the existing location comparison and its comment. Regression fixtures model the main webroot vhost, Vision route/upstream/fallback and Vision ACME output reviewed at immutable 3x-ui commit b1fd00282a887456d974c29e74891c017235050b. The original regression failed on base at the ACME directive comparison and now passes, proving read-only planning, unchanged foreign bytes/ownership/modes, own-vhost-only ACME edits and idempotence before/after WEB integration. Negative cases retain strict refusal. Two documentation lines reflect the optional directive.
Local validation: 32 parser/security tests, 23 CI/identity meta-tests, existing ACME/failure fixtures (including Vision), real Nginx with the complete pinned fixture plus Vision, rollback, syntax, ShellCheck, manifest, docs/pins and diff checks passed. Full exact-HEAD Actions run 39013676141 passed all 11 jobs on its first attempt, including native root renewal, Ubuntu 24.04/26.04, ARM64, Commit identity and CI / Required. Hosted regression passed 215 discovery tests, 40 transaction tests and 9 bootstrap/recovery tests. No real ACME issuance, Xray/Vision client session or VPS deployment is claimed. No version/pin, transport, template, hook, scheduler, updater or upstream-repository changes.