Spectrum Analyzer: hold last peak, persist settings; Freq Analyzer [Ext]: radio parked-state fix - #235
Merged
Merged
Conversation
- Keep the last detected peak label on screen (prefixed "Last:" once the signal is gone) until a new peak replaces it, so short bursts can be read after the fact (#100) - Save frequency, spectrum width, modulation and vscroll on exit and restore them on the next launch, with range validation on load (#99) - Apply restored modulation to the worker on startup - Bump fap_version to 1.5 Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
- Latch the peak frequency measured by the worker at sweep time and pass it through the callback, so a retune during a sweep cannot latch a mislabeled "Last:" frequency - Log a warning when out-of-range saved settings are discarded - Document the long-press OK modulation toggle in the README and clarify when the "Last:" prefix appears - Fix stale/imprecise comments from the previous commit Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Port of DarkFlippers/unleashed-firmware#1045: the worker parked the active radio (internal or external CC1101) with its custom near-field AGC/BW registers retained through SPWD sleep, and the internal RF switch left isolated. Reset the radio and re-park the RF path on exit so the chip is left in the same state as after boot. Note: this app is not buildable under the standalone ufbt SDK (it depends on firmware-internal headers); verified the failure predates this change against the pristine tree. The touched functions are all already used in this file, so no new API surface is introduced. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
github-actions
Bot
added
pack/base
Backfilled from git history following the repo convention (see tetris_game, calculator). Freq Analyzer [Ext] never had a fap_version; set it to 1.2, retroactively labeling the 2FSK preset support as 1.1. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Spectrum Analyzer (v1.5)
Closes #100 - the peak label vanished with the next sweep (~0.5 s), making short bursts impossible to read:
Peak:while the signal is live,Last:once it is goneCloses #99 (stage 1) - nothing was persisted across launches:
saved_structto the app data folder and restored on launch, with all-or-nothing range validation (themodulationbound doubles as memory safety - it indexes a 2-element preset array in the worker)Reviewed by the pr-review-toolkit agents (code / comments / silent-failures); all findings addressed. Built and flashed on hardware: Target 7, API 88.0.
Freq Analyzer [Ext]
Port of DarkFlippers/unleashed-firmware#1045: the worker parked the active radio (internal or external CC1101) with its custom near-field AGC/BW registers retained through SPWD sleep and the internal RF switch isolated - the same "sticky sensitivity loss" mechanism fixed in firmware. The worker now resets the radio and re-parks the RF path on exit, leaving the chip in its boot state.
Note: this app is not buildable under the standalone ufbt SDK (it depends on firmware-internal headers - pre-existing, verified against the pristine tree); the touched functions are all already used in the same file.
🤖 Generated with Claude Code