Skip to content

refactor: update argument parsing for multi-machine launches. - #2081

Open
XuZhang99 wants to merge 1 commit into
xLLM-AI:mainfrom
XuZhang99:feat/multi
Open

refactor: update argument parsing for multi-machine launches.#2081
XuZhang99 wants to merge 1 commit into
xLLM-AI:mainfrom
XuZhang99:feat/multi

Conversation

@XuZhang99

@XuZhang99 XuZhang99 commented Jul 30, 2026

Copy link
Copy Markdown
Collaborator

Description

This Refactor is for xllm serve(python-interface launch method).

  • Renamed --node_rank to --machine_rank for clarity.
  • Enhanced help descriptions for --machine_rank and --nnodes.
  • Added validation for --machine_rank and device count detection.
  • Introduced _reject_managed_flags to prevent manual setting of --node_rank.
  • Updated launch target resolution to accommodate multi-machine configurations.

Related Issues

Change Type

  • Bug fix
  • New feature
  • Performance improvement
  • Refactor
  • Documentation
  • Test
  • Build or CI

Pull Request Checklist

Thank you for contributing to xLLM. Before requesting review, please make sure the following items are complete.

PR Title and Commit Messages

  • The PR title and each commit message follow the xLLM commit format: <type>: <subject>.

Allowed types: feat, bugfix, docs, test, refactor, chore, style, revert, perf, model, build, release.
The subject should use clear English, start with a verb, include at least 4 words, and end with ..

Pre-commit Checks

  • I have installed pre-commit by running pip install pre-commit or an equivalent command.
  • I have installed the hooks with pre-commit install.
  • I have run pre-commit run --all-files and fixed any reported issues.

If you are unsure how to set up pre-commit, see the pre-commit documentation.

Self Review

  • I have self-reviewed the code according to .agents/skills/code-review/references/custom-code-style.md, especially code written or assisted by AI.
  • I have rebased this PR onto the latest main branch.

Build and Test Coverage

  • Tests have been added or updated as needed.
  • CUDA: python setup.py build test has passed on a CUDA machine.
  • NPU: python setup.py build test has passed on an NPU machine.
  • MLU: python setup.py build test has passed on an MLU machine.

Reviewer Notes

…server.

- Renamed `--node_rank` to `--machine_rank` for clarity.
- Enhanced help descriptions for `--machine_rank` and `--nnodes`.
- Added validation for `--machine_rank` and device count detection.
- Introduced `_reject_managed_flags` to prevent manual setting of `--node_rank`.
- Updated launch target resolution to accommodate multi-machine configurations.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant