feat(notes_ui): reach universal logos_beacon via QtRO backend (logos-notes#105)#106
Open
xAlisher wants to merge 1 commit into
Open
feat(notes_ui): reach universal logos_beacon via QtRO backend (logos-notes#105)#106xAlisher wants to merge 1 commit into
xAlisher wants to merge 1 commit into
Conversation
…notes#105)
notes_ui called logos_beacon via logos.callModule, which now returns "null"
since logos_beacon is a Qt-free universal module (2.0.0). Add a notes_ui QtRO
backend (notes_ui.rep + notes_ui_backend.{h,cpp}) that forwards getBeaconConfig,
getInscriptionLog, and pinCid to modules().logos_beacon.*, and switch Main.qml's
three logos_beacon calls to logos.watch(backend.m(...)) with async callbacks.
notes/stash/keycard stay on legacy callModule.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #105. notes_ui called logos_beacon via callModule (getBeaconConfig/pinCid/getInscriptionLog) → returns "null" now that logos_beacon is universal — notes' inscription-backup path was broken.
Fix (beacon recipe): QtRO backend (src/notes_ui.rep + notes_ui_backend.{h,cpp}) forwarding the 3 methods to modules().logos_beacon.*; Main.qml → logos.module("notes_ui") + logos.watch; sync inscribe extracted to an async beaconInscribe(); readiness-gated. notes/stash/keycard stay on callModule (legacy). No zone_sequencer usage.
Verification: nix build .#lgx → EXIT=0 (codegen first try). Runtime inscription = wetware. DWeb Sprint 4.