Conversation
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
This PR is being reviewed by Cursor Bugbot
Details
You are on the Bugbot Free tier. On this plan, Bugbot will review limited PRs each billing cycle.
To receive Bugbot reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial.
| time: simulation time | ||
| dt: time step | ||
| pause: if True, the simulation will pause after the specified time (stop after step 1); | ||
| pause: if True, the simulation will pause after the specified time; |
There was a problem hiding this comment.
Documented pause parameter is never used
Medium Severity
The simulate method's pause parameter is documented to pause the simulation after the specified time to allow parameter changes, but the parameter is never actually used in the function body. The docstring and Documentation.md describe specific behavior ("if True, the simulation pauses after the specified time...") that is not implemented. Users relying on this documented feature will find it has no effect.


Note
Medium Risk
Touches core simulation state/initialization logic to support continuing runs after parameter changes, which could subtly alter model behavior; however changes are covered by a large new regression test suite and are mostly additive/cleanup elsewhere.
Overview
v0.7.2 updates core simulation for interactive/stepwise runs and streamlines the package. The simulation engine now better supports calling
simulate()multiple times (including afterreplace_element_equation) by preserving stock values when re-initializing from achangedstate, allowing continuation fromsimulated, and marking modified stocks as uninitialized.Adds a new CLI subcommand
asdm run <model.stmx>to run a model headlessly and export results to CSV, and introduces an extensive new test suite (test_varying_parameters.py) validating continuity, state transitions, and parameter-change effects for both programmatic and.stmx-loaded models.Cleans up packaging by bumping
pyproject.tomlto0.7.2, removing legacy inference/optimization modules undersrc/asdm/Inference/and deletingutilities.py, and refreshesREADME.md/Documentation.mdwith expanded, reorganized user-facing docs (simulation specs, arrays, conveyors, data import, function reference, XMILE export).Written by Cursor Bugbot for commit 9c9c3b6. This will update automatically on new commits. Configure here.