Skip to content

of2306#10

Open
HenningScheufler wants to merge 5 commits into
wyldckat:OF5xfrom
HenningScheufler:of2306
Open

of2306#10
HenningScheufler wants to merge 5 commits into
wyldckat:OF5xfrom
HenningScheufler:of2306

Conversation

@HenningScheufler

Copy link
Copy Markdown

Port to of2306

The current port updates the libcgnsoo_3.0 to the meson build system for better maintainability.

It also compiles the cgns implementation of SU2 with hdf5, mpi and zlib support

Limitation (WIP):

  • It does not detect the system version of cgns/hdf5 on the system
  • Copying the SU2 variant might be difficult to maintain.

@wyldckat

Copy link
Copy Markdown
Owner

@HenningScheufler: Many+many thanks! I've taken a quick look into what you've done, it looks to be very good!
I need a few more days to find some time to create a branch for this, test it and merge the pull request.

Nonetheless, the first thing that comes to mind, would be to revise the script to download CGNS from its origin, instead of keeping a local copy. I say this due to the current repo being under one open-source license and CGNS is using another, if I'm not mistaken.

@HenningScheufler

Copy link
Copy Markdown
Author

I modified the code from from the su2 project and they have LGPL.

A modified version can be found here that download and compile the sources from github:

https://github.com/HenningScheufler/cgnsToFromFoam/tree/feature-wrap

However, the integration with meson is not perfect.

@HenningScheufler

Copy link
Copy Markdown
Author

Thx for the quick response. I also need to improve it further just wanted to inform you early that im working on it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants