Update finch to 0.6.3 and needletail to 0.7#301
Conversation
finch 0.6.3 requires needletail ^0.7, and needletail carries a `links = "lzma"` native library, so only one needletail major version can exist in the dependency tree. Move coverm's direct needletail dependency from 0.5.* to 0.7.* to match. galah is the other consumer of finch/needletail in the tree. Its published 0.5.2 still pins needletail 0.5.*, which is incompatible with needletail 0.7, so depend on galah from git (main already uses needletail 0.7 and finch 0.6.*) until a galah release with needletail 0.7 is published. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01RgeCVEEvbQV5aZR6yST5FU
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 5edb965c64
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| # galah = "0.4.0" | ||
| galah = ">=0.5.1, <0.6.0" | ||
| # galah = ">=0.5.1, <0.6.0" # published 0.5.2 pins needletail 0.5; use git until a release with needletail 0.7 is published | ||
| galah = { git = "https://github.com/wwood/galah" } |
There was a problem hiding this comment.
For release builds that follow this repo's release.sh/release.py flow and then run cargo publish, this git-only dependency makes the crate unpublishable on crates.io: Cargo rejects non-dev dependencies sourced from git/path/other registries, and CoverM's release script explicitly ends by asking the maintainer to publish. This should wait for a published galah release compatible with needletail 0.7, or use a publishable dependency arrangement before merging.
Useful? React with 👍 / 👎.
2 participants
finch 0.6.3 requires needletail ^0.7, and needletail carries a
links = "lzma"native library, so only one needletail major versioncan exist in the dependency tree. Move coverm's direct needletail
dependency from 0.5.* to 0.7.* to match.
galah is the other consumer of finch/needletail in the tree. Its
published 0.5.2 still pins needletail 0.5., which is incompatible with
needletail 0.7, so depend on galah from git (main already uses
needletail 0.7 and finch 0.6.) until a galah release with needletail
0.7 is published.
Co-Authored-By: Claude Opus 4.8 noreply@anthropic.com
Claude-Session: https://claude.ai/code/session_01RgeCVEEvbQV5aZR6yST5FU