Fix gallery tests for current GPT-5.6 run registry#6
Merged
Conversation
The cleanup kept luna-3, sol-high, and terra-high while dropping luna, luna-high, and sol-high-2. Sync the gallery assertions so pnpm test no longer expects the deleted luna-2 / sol-high-2 ids. Co-authored-by: Stephen Wu <wustep@users.noreply.github.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
wustep
added a commit
that referenced
this pull request
Jul 11, 2026
The amber focus ring (--amber, 80% lightness) scored only 1.65:1 against the light surface and 1.81:1 on white rows — below WCAG 2.2's 3:1 focus-appearance minimum — so keyboard focus was hard to locate. Add a --focus token (the near-black --ink) for controls on light surfaces (15.6:1 on the surface, 17:1 on white) and a white ring for controls on the red chassis (hero and preview/report overlays). Amber is kept only on the dark toy panel, where it reads well (octave buttons, pitch/mod wheels, keybed). Idea #6 from specs/improvements-2026-07-11.md. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The gallery registry assertions still expected
gpt-5-6-luna-2andgpt-5-6-sol-high-2, which were removed in the GPT-5.6 run cleanup.runs.jsoncorrectly lists the kept runs (gpt-5-6-luna-3,gpt-5-6-sol-high,gpt-5-6-terra-high).This updates
tests/gallery.test.mjsto assert those current ids and treatgpt-5-6-sol-high-2as superseded, sopnpm testpasses again.