Skip to content

Add integration tests for Debug Framework REST API#27842

Open
LinukaAr wants to merge 1 commit into
wso2:masterfrom
LinukaAr:idp-validator
Open

Add integration tests for Debug Framework REST API#27842
LinukaAr wants to merge 1 commit into
wso2:masterfrom
LinukaAr:idp-validator

Conversation

@LinukaAr

Copy link
Copy Markdown
Contributor

$subject

@coderabbitai

coderabbitai Bot commented May 23, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 7c4a5084-be3f-4bab-8a42-0981312790b4

📥 Commits

Reviewing files that changed from the base of the PR and between b3dead8 and d12b7e2.

📒 Files selected for processing (9)
  • modules/integration/tests-integration/tests-backend/src/test/java/org/wso2/identity/integration/test/rest/api/server/debug/v1/DebugFailureTest.java
  • modules/integration/tests-integration/tests-backend/src/test/java/org/wso2/identity/integration/test/rest/api/server/debug/v1/DebugSuccessTest.java
  • modules/integration/tests-integration/tests-backend/src/test/java/org/wso2/identity/integration/test/rest/api/server/debug/v1/DebugTestBase.java
  • modules/integration/tests-integration/tests-backend/src/test/resources/org/wso2/identity/integration/test/rest/api/server/debug/v1/add-github-idp.json
  • modules/integration/tests-integration/tests-backend/src/test/resources/org/wso2/identity/integration/test/rest/api/server/debug/v1/add-google-idp.json
  • modules/integration/tests-integration/tests-backend/src/test/resources/org/wso2/identity/integration/test/rest/api/server/debug/v1/add-idp-without-authenticator.json
  • modules/integration/tests-integration/tests-backend/src/test/resources/org/wso2/identity/integration/test/rest/api/server/debug/v1/add-oidc-idp.json
  • modules/integration/tests-integration/tests-backend/src/test/resources/org/wso2/identity/integration/test/rest/api/server/debug/v1/add-saml-idp.json
  • modules/integration/tests-integration/tests-backend/src/test/resources/testng.xml

📝 Walkthrough

Walkthrough

This pull request introduces a comprehensive test suite for the Debug Framework REST API. The changes establish a base test class (DebugTestBase) that provides shared API constants and lifecycle management, add five IDP configuration test fixtures, and implement two test classes covering both success and failure scenarios. DebugSuccessTest validates debug session startup across OIDC, Google, and GitHub identity providers and verifies authorization URL structure. DebugFailureTest exercises error cases including invalid request parameters, missing authenticators, and malformed debug IDs. The test classes are parameterized for multi-tenant contexts and integrated into the existing TestNG suite.

Suggested reviewers

  • SujanSanjula96
🚥 Pre-merge checks | ✅ 3 | ❌ 2

❌ Failed checks (2 warnings)

Check name Status Explanation Resolution
Description check ⚠️ Warning The pull request description is empty (placeholder text '$subject'), providing no information about the changeset. Provide a meaningful description explaining the purpose of the integration tests, what aspects of the Debug Framework REST API are covered, and any relevant context for reviewers.
Docstring Coverage ⚠️ Warning Docstring coverage is 2.78% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The pull request title directly describes the main change: adding integration tests for the Debug Framework REST API, which aligns with the changeset containing test classes and resources.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Warning

Review ran into problems

🔥 Problems

Git: Failed to clone repository. Please run the @coderabbitai full review command to re-trigger a full review. If the issue persists, set path_filters to include or exclude specific files.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@sonarqubecloud

Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant