fix: correct invalid aria-label attribute#10549
Conversation
📝 WalkthroughWalkthroughThe local claim attribute dropdown now uses the valid lowercase ChangesAttribute accessibility
Important Pre-merge checks failedPlease resolve all errors before merging. Addressing warnings is optional. ❌ Failed checks (1 error)
✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Could you please add a screenshot of how this aria-label is getting applied in the console UI, in the pr description? |
|
@pavinduLakshan Thanks for the review! I've updated the PR description with the requested screenshot showing the Console UI where the corrected |
Sorry, what I meant was a screenshot of the aria-label attribute being properly applied to the UI element. You can inspect the webpage, open the browser devtools panel and take a screenshot from it. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #10549 +/- ##
========================================
Coverage 72.90% 72.91%
========================================
Files 470 470
Lines 71365 71383 +18
Branches 448 240 -208
========================================
+ Hits 52029 52047 +18
- Misses 19040 19225 +185
+ Partials 296 111 -185 🚀 New features to boost your workflow:
|
|
@pavinduLakshan Thank you for the clarification. I have updated the PR description with a DevTools screenshot showing the valid |
Purpose
Fixes the invalid
aria-Labelattribute reported by React Doctor by replacing it with the validaria-labelattribute.Related Issues
aria-Labelis not a valid ARIA property — check WAI-ARIA spec (1 occurrence) product-is#27873Related PRs
Checklist
Security checks
Developer Checklist (Mandatory)
product-isissue to track any behavioral change or migration impact.Screenshots
The following DevTools screenshot shows the valid
aria-label="Local Claim Attribute"applied to the rendered Maps to combobox in the Onfido Identity Verification Provider's Add Attribute Mappings modal.