Skip to content

fix: correct invalid aria-label attribute#10549

Open
Pravinath wants to merge 1 commit into
wso2:masterfrom
Pravinath:fix-27873-invalid-aria-label
Open

fix: correct invalid aria-label attribute#10549
Pravinath wants to merge 1 commit into
wso2:masterfrom
Pravinath:fix-27873-invalid-aria-label

Conversation

@Pravinath

@Pravinath Pravinath commented Jul 18, 2026

Copy link
Copy Markdown

Purpose

Fixes the invalid aria-Label attribute reported by React Doctor by replacing it with the valid aria-label attribute.

Related Issues

Related PRs

  • N/A

Checklist

  • Manual test round performed and verified.

Security checks

  • Confirmed that this PR doesn't commit any keys, passwords, tokens, usernames, or other secrets

Developer Checklist (Mandatory)

  • Complete the Developer Checklist in the related product-is issue to track any behavioral change or migration impact.

Screenshots

The following DevTools screenshot shows the valid aria-label="Local Claim Attribute" applied to the rendered Maps to combobox in the Onfido Identity Verification Provider's Add Attribute Mappings modal.

Screenshot 2026-07-19 005855

@coderabbitai

coderabbitai Bot commented Jul 18, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

📝 Walkthrough

Walkthrough

The local claim attribute dropdown now uses the valid lowercase aria-label accessibility property instead of aria-Label.

Changes

Attribute accessibility

Layer / File(s) Summary
Correct dropdown ARIA property
features/admin.identity-verification-providers.v1/components/edit/attribute-mapping/attribute-mapping-list-item.tsx
Updates the local claim attribute dropdown from aria-Label to aria-label.

Important

Pre-merge checks failed

Please resolve all errors before merging. Addressing warnings is optional.

❌ Failed checks (1 error)

Check name Status Explanation Resolution
Changeset Required ❌ Error HEAD changes only the feature TSX file and no non-README .changeset/*.md file is included, so a changeset is missing. Add a new .changeset/*.md file for this feature change, listing the affected package(s) and the appropriate version bump.
✅ Passed checks (5 passed)
Check name Status Explanation
Linked Issues check ✅ Passed The change addresses issue #27873 by replacing invalid aria-Label with valid aria-label in the affected component.
Out of Scope Changes check ✅ Passed The PR is narrowly scoped to the reported accessibility attribute fix and includes no unrelated changes.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Title check ✅ Passed The title clearly and concisely describes the main change: fixing the invalid aria-label attribute.
Description check ✅ Passed The description covers purpose, related issue, testing, security, checklist, and includes a screenshot, matching the template well.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • 🛠️ create changeset

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@pavinduLakshan

Copy link
Copy Markdown
Member

Could you please add a screenshot of how this aria-label is getting applied in the console UI, in the pr description?

@Pravinath

Copy link
Copy Markdown
Author

@pavinduLakshan Thanks for the review! I've updated the PR description with the requested screenshot showing the Console UI where the corrected aria-label is applied to the User Attribute to map to dropdown. Please let me know if any further changes are needed.

@pavinduLakshan

Copy link
Copy Markdown
Member

@pavinduLakshan Thanks for the review! I've updated the PR description with the requested screenshot showing the Console UI where the corrected aria-label is applied to the User Attribute to map to dropdown. Please let me know if any further changes are needed.

Sorry, what I meant was a screenshot of the aria-label attribute being properly applied to the UI element. You can inspect the webpage, open the browser devtools panel and take a screenshot from it.

@codecov

codecov Bot commented Jul 18, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 72.91%. Comparing base (7900686) to head (3745cae).
⚠️ Report is 90 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff            @@
##           master   #10549    +/-   ##
========================================
  Coverage   72.90%   72.91%            
========================================
  Files         470      470            
  Lines       71365    71383    +18     
  Branches      448      240   -208     
========================================
+ Hits        52029    52047    +18     
- Misses      19040    19225   +185     
+ Partials      296      111   -185     

see 188 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Pravinath

Copy link
Copy Markdown
Author

@pavinduLakshan Thank you for the clarification. I have updated the PR description with a DevTools screenshot showing the valid aria-label="Local Claim Attribute" applied to the rendered combobox element. Please let me know if any further changes are needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[React Doctor] aria-props: aria-Label is not a valid ARIA property — check WAI-ARIA spec (1 occurrence)

2 participants