Fix CDS UI related issues#10543
Conversation
…tures Require an accessible preview feature to gate the Feature Preview menu, so it stays hidden when the unified Customer Data view filters CDS out of the list while the SaaS/preview-features feature gates are enabled.
In unified Customer Data view, the home-page CDS banner always shows Try Out (for both enabled and disabled cases) and navigates to the customer-data page instead of opening the Feature Preview modal or the profiles page.
The profile details back button and post-delete redirect now navigate to the unified Customer Data page instead of the standalone Profiles page when the unified Customer Data view is enabled.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughChangesCDS profile experience
Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 4 | ❌ 2❌ Failed checks (1 warning, 1 inconclusive)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
🧹 Nitpick comments (1)
features/admin.cds.v1/components/profile.tsx (1)
491-491: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick winAdd explicit return type annotations to arrow functions.
As per coding guidelines, avoid relying on type inference and use explicit type annotations everywhere. Add the
voidreturn type to these event handler functions to maintain consistency.
features/admin.cds.v1/components/profile.tsx#L491-L491: updateonClick: () =>toonClick: (): void =>.features/admin.home.v1/components/new-feature-announcement/new-feature-announcement.tsx#L286-L286: updateonTryOut: () => {toonTryOut: (): void => {.♻️ Proposed fixes
features/admin.cds.v1/components/profile.tsx
- onClick: () => history.push(AppConstants.getPaths().get(profilesListPath)), + onClick: (): void => history.push(AppConstants.getPaths().get(profilesListPath)),features/admin.home.v1/components/new-feature-announcement/new-feature-announcement.tsx
- onTryOut: () => { + onTryOut: (): void => {🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@features/admin.cds.v1/components/profile.tsx` at line 491, add explicit void return type annotations to the event handler arrow functions: update onClick in features/admin.cds.v1/components/profile.tsx at lines 491-491 to use (): void, and update onTryOut in features/admin.home.v1/components/new-feature-announcement/new-feature-announcement.tsx at lines 286-286 the same way.Source: Coding guidelines
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In `@features/admin.cds.v1/components/profile.tsx`:
- Line 491: add explicit void return type annotations to the event handler arrow
functions: update onClick in features/admin.cds.v1/components/profile.tsx at
lines 491-491 to use (): void, and update onTryOut in
features/admin.home.v1/components/new-feature-announcement/new-feature-announcement.tsx
at lines 286-286 the same way.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yml
Review profile: CHILL
Plan: Pro
Run ID: 0fbe76b2-49b5-4590-8ad6-e329bc4e28e8
📒 Files selected for processing (3)
features/admin.cds.v1/components/profile.tsxfeatures/admin.core.v1/hooks/use-preview-features.tsfeatures/admin.home.v1/components/new-feature-announcement/new-feature-announcement.tsx
Purpose
$Subject