Skip to content

Fix CDS UI related issues#10543

Merged
SujanSanjula96 merged 5 commits into
wso2:masterfrom
SujanSanjula96:hotfix-cds
Jul 15, 2026
Merged

Fix CDS UI related issues#10543
SujanSanjula96 merged 5 commits into
wso2:masterfrom
SujanSanjula96:hotfix-cds

Conversation

@SujanSanjula96

Copy link
Copy Markdown
Contributor

Purpose

$Subject

…tures

Require an accessible preview feature to gate the Feature Preview menu, so
it stays hidden when the unified Customer Data view filters CDS out of the
list while the SaaS/preview-features feature gates are enabled.
In unified Customer Data view, the home-page CDS banner always shows Try Out
(for both enabled and disabled cases) and navigates to the customer-data page
instead of opening the Feature Preview modal or the profiles page.
The profile details back button and post-delete redirect now navigate to the
unified Customer Data page instead of the standalone Profiles page when the
unified Customer Data view is enabled.
@coderabbitai

coderabbitai Bot commented Jul 15, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yml

Review profile: CHILL

Plan: Pro

Run ID: 95e1238a-7777-4255-85d4-2cf6c5f8af42

📥 Commits

Reviewing files that changed from the base of the PR and between 6d6a075 and dc1e925.

📒 Files selected for processing (1)
  • .changeset/cds-unified-view-navigation-fixes.md

📝 Walkthrough

Walkthrough

Changes

CDS profile experience

Layer / File(s) Summary
Unified profile navigation and announcement routing
features/admin.cds.v1/components/profile.tsx, features/admin.home.v1/components/new-feature-announcement/new-feature-announcement.tsx, .changeset/cds-unified-view-navigation-fixes.md
Profile deletion, back navigation, and the customer data platform announcement route to CUSTOMER_DATA_PROFILE when unified profile mode is enabled; the changeset records patch releases for the affected packages.
Preview feature eligibility
features/admin.core.v1/hooks/use-preview-features.ts
Preview features now require enabled SaaS and preview feature statuses plus accessible preview features.

Possibly related PRs

Suggested reviewers: pasinduyeshan

🚥 Pre-merge checks | ✅ 4 | ❌ 2

❌ Failed checks (1 warning, 1 inconclusive)

Check name Status Explanation Resolution
Description check ⚠️ Warning The description only contains the Purpose placeholder and omits the required sections from the template. Fill in Purpose with a concrete summary and add the Related Issues, Related PRs, checklist, security checks, and Developer Checklist sections.
Title check ❓ Inconclusive The title is related to the PR, but it is too generic to convey the main CDS navigation fixes. Use a more specific title, such as fixing CDS unified profile navigation and preview feature gating.
✅ Passed checks (4 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Changeset Required ✅ Passed PASS: The PR diff includes a new .changeset file, and it lists all changed packages with patch bumps.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • 🛠️ create changeset

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@coderabbitai
coderabbitai Bot requested a review from PasinduYeshan July 15, 2026 16:20

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick comments (1)
features/admin.cds.v1/components/profile.tsx (1)

491-491: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick win

Add explicit return type annotations to arrow functions.

As per coding guidelines, avoid relying on type inference and use explicit type annotations everywhere. Add the void return type to these event handler functions to maintain consistency.

  • features/admin.cds.v1/components/profile.tsx#L491-L491: update onClick: () => to onClick: (): void =>.
  • features/admin.home.v1/components/new-feature-announcement/new-feature-announcement.tsx#L286-L286: update onTryOut: () => { to onTryOut: (): void => {.
♻️ Proposed fixes

features/admin.cds.v1/components/profile.tsx

-                onClick: () => history.push(AppConstants.getPaths().get(profilesListPath)),
+                onClick: (): void => history.push(AppConstants.getPaths().get(profilesListPath)),

features/admin.home.v1/components/new-feature-announcement/new-feature-announcement.tsx

-            onTryOut: () => {
+            onTryOut: (): void => {
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@features/admin.cds.v1/components/profile.tsx` at line 491, add explicit void
return type annotations to the event handler arrow functions: update onClick in
features/admin.cds.v1/components/profile.tsx at lines 491-491 to use (): void,
and update onTryOut in
features/admin.home.v1/components/new-feature-announcement/new-feature-announcement.tsx
at lines 286-286 the same way.

Source: Coding guidelines

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Nitpick comments:
In `@features/admin.cds.v1/components/profile.tsx`:
- Line 491: add explicit void return type annotations to the event handler arrow
functions: update onClick in features/admin.cds.v1/components/profile.tsx at
lines 491-491 to use (): void, and update onTryOut in
features/admin.home.v1/components/new-feature-announcement/new-feature-announcement.tsx
at lines 286-286 the same way.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yml

Review profile: CHILL

Plan: Pro

Run ID: 0fbe76b2-49b5-4590-8ad6-e329bc4e28e8

📥 Commits

Reviewing files that changed from the base of the PR and between 669306f and 6d6a075.

📒 Files selected for processing (3)
  • features/admin.cds.v1/components/profile.tsx
  • features/admin.core.v1/hooks/use-preview-features.ts
  • features/admin.home.v1/components/new-feature-announcement/new-feature-announcement.tsx

Comment thread .changeset/cds-unified-view-navigation-fixes.md
@SujanSanjula96
SujanSanjula96 merged commit dd42d48 into wso2:master Jul 15, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants