Fix 'Include organization name' cleared when unchecking 'Include user domain' in application subject settings#10541
Conversation
…n in application subject settings
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughThe application attribute settings form now tracks user-domain and tenant-domain subject identifier options independently, submits both values separately, and records the fix in a patch Changesets entry. ChangesSubject domain flag persistence
Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 6✅ Passed checks (6 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #10541 +/- ##
=======================================
Coverage 72.85% 72.85%
=======================================
Files 470 470
Lines 71228 71228
Branches 240 240
=======================================
Hits 51892 51892
Misses 19225 19225
Partials 111 111 🚀 New features to boost your workflow:
|
Problem
In the Console application editor (User Attributes → Subject → "Assign alternate subject identifier"), un-checking Include user domain while Include organization name was checked silently cleared the organization-name flag on save (and vice versa). The persisted configuration came back with both flags off.
Fix
The two subject-domain checkboxes (
Field.CheckboxLegacy) had no external state and nolistenhandler, so their value was tracked only inside react-final-form on an uncontrolled checkbox and was lost on a sibling re-render. Give both parent-owned React state withlistenhandlers and read that state insubmitValues, mirroring the existing linked-account checkboxes. The two flags now persist independently.Single-file, Console-UI only. No server-side, REST, or config change.
Fixes wso2/product-is#28180