Skip to content

Improve the UX of user creation for secondary user stores from the console app#10479

Open
vismayigur wants to merge 2 commits into
wso2:masterfrom
vismayigur:fix-issue-1
Open

Improve the UX of user creation for secondary user stores from the console app#10479
vismayigur wants to merge 2 commits into
wso2:masterfrom
vismayigur:fix-issue-1

Conversation

@vismayigur

@vismayigur vismayigur commented Jun 28, 2026

Copy link
Copy Markdown

Purpose

fixes wso2/product-is#21325

Fix the users page user store selector so it preserves the currently selected user store context after the add-user flow.

Previously, when creating a user from a secondary user store context, the users page dropdown could visually fall back to the primary user store because the selector was using a static defaultValue. This PR updates the selector to use the current selectedUserStore state so the UI stays aligned with the active context.

Related Issues

  • N/A

Related PRs

  • N/A

Checklist

  • e2e cypress tests locally verified. (for internal contributers)
  • Manual test round performed and verified.
  • UX/UI review done on the final implementation.
  • Documentation provided. (Add links if there are any)
  • Relevant backend changes deployed and verified
  • Unit tests provided. (Add links if there are any)
  • Integration tests provided. (Add links if there are any)

Security checks

Developer Checklist (Mandatory)

  • Complete the Developer Checklist in the related product-is issue to track any behavioral change or migration impact.

@CLAassistant

CLAassistant commented Jun 28, 2026

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

@coderabbitai

coderabbitai Bot commented Jun 28, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

📝 Walkthrough

Walkthrough

The userstore selector dropdown in the users list page is changed from uncontrolled (defaultValue) to controlled (value), using selectedUserStore state with a fallback to primaryUserstoreName.

Changes

Controlled userstore dropdown

Layer / File(s) Summary
Dropdown controlled value fix
features/admin.users.v1/pages/users.tsx
Replaces defaultValue with value={ selectedUserStore ?? primaryUserstoreName } on the userstore dropdown, making it reflect the current selectedUserStore state.

Important

Pre-merge checks failed

Please resolve all errors before merging. Addressing warnings is optional.

❌ Failed checks (1 error)

Check name Status Explanation Resolution
Changeset Required ❌ Error PR diff vs origin/master includes only features/admin.users.v1/pages/users.tsx; no non-README .changeset/*.md file is present. Add a new .changeset/*.md entry for the feature change (not README), listing the affected package(s) and version bump.
✅ Passed checks (5 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Title check ✅ Passed The title is related to the change, but it is broader than the specific selector state fix in the users page.
Description check ✅ Passed The description follows the template and includes purpose, issue reference, checklist items, security checks, and developer checklist.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • 🛠️ create changeset

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@vismayigur vismayigur changed the title Fix issue #21325 Improve the UX of user creation for secondary user stores from the console app. #21325 Jun 28, 2026
@pavinduLakshan pavinduLakshan changed the title Improve the UX of user creation for secondary user stores from the console app. #21325 Improve the UX of user creation for secondary user stores from the console app Jul 12, 2026
@pavinduLakshan

Copy link
Copy Markdown
Member

Hi @vismayigur, could you please add a screen recording of how your fix works, to the PR description?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Improve the UX of user creation for secondary user stores from the console app.

3 participants