Improve the UX of user creation for secondary user stores from the console app#10479
Open
vismayigur wants to merge 2 commits into
Open
Improve the UX of user creation for secondary user stores from the console app#10479vismayigur wants to merge 2 commits into
vismayigur wants to merge 2 commits into
Conversation
Contributor
📝 WalkthroughWalkthroughThe userstore selector dropdown in the users list page is changed from uncontrolled ( ChangesControlled userstore dropdown
Important Pre-merge checks failedPlease resolve all errors before merging. Addressing warnings is optional. ❌ Failed checks (1 error)
✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Member
|
Hi @vismayigur, could you please add a screen recording of how your fix works, to the PR description? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
fixes wso2/product-is#21325
Fix the users page user store selector so it preserves the currently selected user store context after the add-user flow.
Previously, when creating a user from a secondary user store context, the users page dropdown could visually fall back to the primary user store because the selector was using a static
defaultValue. This PR updates the selector to use the currentselectedUserStorestate so the UI stays aligned with the active context.Related Issues
Related PRs
Checklist
Security checks
Developer Checklist (Mandatory)
product-isissue to track any behavioral change or migration impact.